Use TaskScheduler instead of WorkerPool in multi_threaded_cert_verifier.cc.

net/cert_net/nss_ocsp_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert_net/nss_ocsp.h"
 
 #include <string>
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/test/scoped_async_task_scheduler.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_completion_callback.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_proc.h"
 #include "net/cert/cert_verify_proc_nss.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/multi_threaded_cert_verifier.h"
 #include "net/cert/test_root_certs.h"
 #include "net/cert/x509_certificate.h"
@@ skipping 92 matching lines @@
   }
 
   int request_count() const {
     return handler_->request_count();
   }
 
  protected:
   const CertificateList empty_cert_list_;
 
  private:
+  // Required by MultiThreadedCertVerifier. Needs to be a

[Ryan Sleevi, 2017/02/07 22:52:09]

This seems to be an undesirable coupling.

It also seems to suggest that TaskScheduler is having the dependency issues that
I highlighted (re: net threads and IO threads and worker threads).

Perhaps we should setup another GVC to figure out how to look at this
holistically?

+  // ScopedAsyncTaskScheduler rather than a ScopedTaskScheduler because the task
+  // posted by MultiThreadedCertVerifier synchronously waits for a task running
+  // on the main thread (OCSPRequestSession::Wait).
+  base::test::ScopedAsyncTaskScheduler scoped_async_task_scheduler_;
   TestURLRequestContext context_;
   AiaResponseHandler* handler_;
   scoped_refptr<CertVerifyProc> verify_proc_;
   std::unique_ptr<CertVerifier> verifier_;
 };
 
 // Tests that when using NSS to verify certificates, and IO is enabled,
 // that a request to fetch missing intermediate certificates is
 // made successfully.
 TEST_F(NssHttpTest, TestAia) {
@@ skipping 21 matching lines @@
 
   error = test_callback.WaitForResult();
 
   EXPECT_THAT(error, IsOk());
 
   // Ensure that NSS made an AIA request for the missing intermediate.
   EXPECT_LT(0, request_count());
 }
 
 }  // namespace net