Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2602183002: Comment out two duplicate lines in TestExpectations (Closed)

Created:
3 years, 11 months ago by jeffcarp
Modified:
3 years, 11 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment out two duplicate lines in TestExpectations One of the tests in question is failing 10% of the time on Windows. BUG=670843 R=qyearsley@chromium.org Committed: https://crrev.com/2b08f5972f60cf29e9594dddf610a20685dc0ef3 Cr-Commit-Position: refs/heads/master@{#441097}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jeffcarp
3 years, 11 months ago (2016-12-30 05:58:48 UTC) #1
qyearsley
lgtm
3 years, 11 months ago (2016-12-31 18:29:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602183002/1
3 years, 11 months ago (2017-01-01 19:12:59 UTC) #4
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-01 21:04:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602183002/20001
3 years, 11 months ago (2017-01-03 06:57:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 07:58:04 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 08:00:29 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b08f5972f60cf29e9594dddf610a20685dc0ef3
Cr-Commit-Position: refs/heads/master@{#441097}

Powered by Google App Engine
This is Rietveld 408576698