[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA histogram is logged when didStartProvisionalNavigation:
fails to add a pending item.

This histogram is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458
Review-Url: https://codereview.chromium.org/2602133002
Cr-Commit-Position: refs/heads/master@{#442047}
Committed: https://chromium.googlesource.com/chromium/src/+/e6fef8190db76bbc5e9716d46296bfda636fad7f

[Eugene But (OOO till 7-30), 2016-12-29 21:30:02]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-12-29 21:30:13]

eugenebut@chromium.org changed reviewers:
+ isherman@chromium.org

[commit-bot: I haz the power, 2016-12-29 21:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 21:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 21:40:17]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-01-06 00:22:45]

Ilya?

[Eugene But (OOO till 7-30), 2017-01-06 19:37:29]

Description was changed from

==========
[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA action is logged when didStartProvisionalNavigation:
fails to add a pending item.

This action is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458
==========

to

==========
[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA histogram is logged when didStartProvisionalNavigation:
fails to add a pending item.

This histogram is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458
==========

[Eugene But (OOO till 7-30), 2017-01-06 19:37:44]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:38:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-01-06 19:50:00]

LGTM % nits, thanks.

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72115: +    empty. It's unclear how app
can get into this state and one assumption is
nit: s/how app/how the app

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72117: +    UMA action is logged when
didStartProvisionalNavigation: fails to add a
nit: s/UMA action/metric

[Eugene But (OOO till 7-30), 2017-01-06 19:55:34]

Thank you!

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72115: +    empty. It's unclear how app
can get into this state and one assumption is
On 2017/01/06 19:50:00, Ilya Sherman (Away De.29-Ja.4) wrote:
> nit: s/how app/how the app

Done.

https://codereview.chromium.org/2602133002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72117: +    UMA action is logged when
didStartProvisionalNavigation: fails to add a
On 2017/01/06 19:50:00, Ilya Sherman (Away De.29-Ja.4) wrote:
> nit: s/UMA action/metric

Done.

[Eugene But (OOO till 7-30), 2017-01-06 19:55:37]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-06 19:55:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2602133002/#ps40001
(title: "Updated comments")

[commit-bot: I haz the power, 2017-01-06 19:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:04:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483732537375060,
"parent_rev": "78b26d84270257a830facd6477ef6e3ff59aca66", "commit_rev":
"e6fef8190db76bbc5e9716d46296bfda636fad7f"}

[commit-bot: I haz the power, 2017-01-06 21:04:56]

Description was changed from

==========
[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA histogram is logged when didStartProvisionalNavigation:
fails to add a pending item.

This histogram is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458
==========

to

==========
[ios] Log UMA if didStartProvisionalNavigation doesn't add pending item.

Chrome for iOS crashes in |didCommitNavigation:| with empty Navigation
Manager. It's unclear how app can get into this state and one assumption
is that didStartProvisionalNavigation: does not add a pending navigation
item. This UMA histogram is logged when didStartProvisionalNavigation:
fails to add a pending item.

This histogram is added only to verify the assumption and should be removed
after M46 is released.

BUG=676458

Review-Url: https://codereview.chromium.org/2602133002
Cr-Commit-Position: refs/heads/master@{#442047}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6fef8190db76bbc5e9716d46296...
==========

[commit-bot: I haz the power, 2017-01-06 21:04:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e6fef8190db76bbc5e9716d46296...