Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2602103002: Delete blimp/helium and remove references to it from dependent targets (Closed)

Created:
3 years, 11 months ago by Kevin M
Modified:
3 years, 11 months ago
Reviewers:
nyquist, Wez
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete blimp/helium. This should not affect the rest of blimp/ build, as there are no components which depend on blimp/helium. BUG=677556 Committed: https://crrev.com/345b473979542dc15d4a4780f9b24a557a7f11fa Cr-Commit-Position: refs/heads/master@{#441549}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : restore top level build #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3940 lines) Patch
M blimp/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D blimp/helium/BUILD.gn View 1 chunk +0 lines, -84 lines 0 comments Download
D blimp/helium/blimp_helium_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/helium/compound_syncable.h View 1 chunk +0 lines, -225 lines 0 comments Download
D blimp/helium/compound_syncable.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D blimp/helium/compound_syncable_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D blimp/helium/errors.h View 1 chunk +0 lines, -13 lines 0 comments Download
D blimp/helium/helium_test.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/helium/lazy_syncable_adapter.h View 1 chunk +0 lines, -116 lines 0 comments Download
D blimp/helium/lazy_syncable_adapter_unittest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D blimp/helium/lww_register.h View 1 chunk +0 lines, -124 lines 0 comments Download
D blimp/helium/lww_register_unittest.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D blimp/helium/mock_objects.h View 1 chunk +0 lines, -58 lines 0 comments Download
D blimp/helium/mock_objects.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D blimp/helium/object_sync_state.h View 1 chunk +0 lines, -113 lines 0 comments Download
D blimp/helium/object_sync_state.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D blimp/helium/owned_register.h View 1 chunk +0 lines, -140 lines 0 comments Download
D blimp/helium/owned_register_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D blimp/helium/result.h View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/helium/result.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D blimp/helium/result_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D blimp/helium/revision_generator.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/helium/revision_generator.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D blimp/helium/revision_generator_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D blimp/helium/serializable.h View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/helium/serializable_struct.h View 1 chunk +0 lines, -125 lines 0 comments Download
D blimp/helium/serializable_struct.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D blimp/helium/serializable_struct_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D blimp/helium/stream.h View 1 chunk +0 lines, -51 lines 0 comments Download
D blimp/helium/stream_helpers.h View 1 chunk +0 lines, -107 lines 0 comments Download
D blimp/helium/stream_helpers.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D blimp/helium/stream_helpers_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D blimp/helium/sync_manager.h View 1 chunk +0 lines, -95 lines 0 comments Download
D blimp/helium/sync_manager.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D blimp/helium/syncable.h View 1 chunk +0 lines, -95 lines 0 comments Download
D blimp/helium/syncable_common.h View 1 chunk +0 lines, -24 lines 0 comments Download
D blimp/helium/syncable_common.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D blimp/helium/transport.h View 1 chunk +0 lines, -53 lines 0 comments Download
D blimp/helium/update_scheduler.h View 1 chunk +0 lines, -72 lines 0 comments Download
D blimp/helium/update_scheduler.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D blimp/helium/update_scheduler_unittest.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D blimp/helium/version_vector.h View 1 chunk +0 lines, -88 lines 0 comments Download
D blimp/helium/version_vector.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D blimp/helium/version_vector_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M blimp/net/BUILD.gn View 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
Kevin M
3 years, 11 months ago (2016-12-29 21:49:25 UTC) #13
Kevin M
m
3 years, 11 months ago (2017-01-03 17:59:02 UTC) #16
Wez
LGTM nit: I'd suggest updating the CL description to clarify that nothing currently depends on ...
3 years, 11 months ago (2017-01-04 00:56:32 UTC) #17
nyquist
lgtm % wez's nit
3 years, 11 months ago (2017-01-04 19:42:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602103002/60001
3 years, 11 months ago (2017-01-05 00:21:31 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2017-01-05 01:45:05 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 01:46:56 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/345b473979542dc15d4a4780f9b24a557a7f11fa
Cr-Commit-Position: refs/heads/master@{#441549}

Powered by Google App Engine
This is Rietveld 408576698