Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2602053003: Reset all members in PrintSettings::Clear. (Closed)

Created:
3 years, 11 months ago by Martin Barbella
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rbpotter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset all members in PrintSettings::Clear. BUG=677395 Committed: https://crrev.com/4b0414c2f976a361a5058beb148e15e57b962d06 Cr-Commit-Position: refs/heads/master@{#440993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M printing/print_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Martin Barbella
PTAL when you get a chance. No clue which default value is more appropriate, but ...
3 years, 11 months ago (2016-12-29 19:13:12 UTC) #2
Martin Barbella
+vitalybuka since Lei is OOO.
3 years, 11 months ago (2016-12-29 19:15:38 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
3 years, 11 months ago (2016-12-29 21:08:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602053003/1
3 years, 11 months ago (2016-12-29 21:08:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 22:11:04 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b0414c2f976a361a5058beb148e15e57b962d06
Cr-Commit-Position: refs/heads/master@{#440993}

Powered by Google App Engine
This is Rietveld 408576698