Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2601993002: Remove base::ScopedPtrHashMap from gpu/ipc/service/. (Closed)

Created:
3 years, 11 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::ScopedPtrHashMap from gpu/ipc/service/. BUG=579229 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4e9384e00eeb05c2558cf731b7494b14d3d5e8bf Cr-Commit-Position: refs/heads/master@{#440941}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M gpu/ipc/service/gpu_channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 6 chunks +15 lines, -6 lines 2 comments Download
M gpu/ipc/service/gpu_channel_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Avi (use Gerrit)
To any reviewer in the office.
3 years, 11 months ago (2016-12-28 22:49:38 UTC) #7
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2601993002/diff/1/gpu/ipc/service/gpu_channel.cc File gpu/ipc/service/gpu_channel.cc (right): https://codereview.chromium.org/2601993002/diff/1/gpu/ipc/service/gpu_channel.cc#newcode903 gpu/ipc/service/gpu_channel.cc:903: stubs_[route_id] = std::move(stub); I confirmed that forgetting the ...
3 years, 11 months ago (2016-12-29 05:41:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601993002/1
3 years, 11 months ago (2016-12-29 06:00:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 06:05:23 UTC) #13
Avi (use Gerrit)
https://codereview.chromium.org/2601993002/diff/1/gpu/ipc/service/gpu_channel.cc File gpu/ipc/service/gpu_channel.cc (right): https://codereview.chromium.org/2601993002/diff/1/gpu/ipc/service/gpu_channel.cc#newcode903 gpu/ipc/service/gpu_channel.cc:903: stubs_[route_id] = std::move(stub); On 2016/12/29 05:41:15, Ken Russell OOO-till-Jan-3 ...
3 years, 11 months ago (2016-12-29 15:18:02 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e9384e00eeb05c2558cf731b7494b14d3d5e8bf
Cr-Commit-Position: refs/heads/master@{#440941}

Powered by Google App Engine
This is Rietveld 408576698