Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

Issue 2601983002: [IndexedDB] Adding transaction and value support to observers (Closed)
Patch Set: Replying to comments, disallowed observing from versionchange txn Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
index 9eed5d7a0ee9dadd411fc71e49b4bc272387716f..fdd99b093f1b1db9e065341bd7a7b50fc72f2f5a 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
@@ -45,6 +45,7 @@
#include "public/platform/modules/indexeddb/WebIDBDatabase.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
+
#include <memory>
namespace blink {
@@ -116,9 +117,13 @@ class MODULES_EXPORT IDBDatabase final
void onVersionChange(int64_t oldVersion, int64_t newVersion);
void onAbort(int64_t, DOMException*);
void onComplete(int64_t);
- void onChanges(const std::unordered_map<int32_t, std::vector<int32_t>>&
- observation_index_map,
- const WebVector<WebIDBObservation>& observations);
+ void onChanges(
+ const std::unordered_map<int32_t, std::vector<int32_t>>&
+ observation_index_map,
+ const WebVector<WebIDBObservation>& observations,
+ const std::unordered_map<int32_t,
+ std::pair<int64_t, std::vector<int64_t>>>&
+ transactions);
// ScriptWrappable
bool hasPendingActivity() const final;
@@ -149,6 +154,7 @@ class MODULES_EXPORT IDBDatabase final
static int64_t nextTransactionId();
static int32_t nextObserverId();
+ static const char cannotObserveVersionChangeTransaction[];
static const char indexDeletedErrorMessage[];
static const char indexNameTakenErrorMessage[];
static const char isKeyCursorErrorMessage[];

Powered by Google App Engine
This is Rietveld 408576698