third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h - Issue 2601983002: [IndexedDB] Adding transaction and value support to observers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h

Issue 2601983002: [IndexedDB] Adding transaction and value support to observers (Closed)

Patch Set: Replying to comments, disallowed observing from versionchange txn Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h b/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h

index b120c14d246ba12c56075e45f6838970cfe756b1..55892e3d3e63bc11e97efae3bfa10c15bab6e0cc 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h

@@ -56,7 +56,10 @@ class MODULES_EXPORT IDBDatabaseCallbacks

virtual void onChanges(

const std::unordered_map<int32_t, std::vector<int32_t>>&

observation_index_map,

- const WebVector<WebIDBObservation>& observations);

+ const WebVector<WebIDBObservation>& observations,

+ const std::unordered_map<int32_t,

pwnall 2017/01/10 01:41:11 Can you alias this type to a meaningful name?

dmurph 2017/01/10 20:40:08 Done.

+ std::pair<int64_t, std::vector<int64_t>>>&

+ transactions);

void connect(IDBDatabase*);