Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2601953002: Start documentation of text stack in platform/fonts (Closed)

Created:
3 years, 11 months ago by drott
Modified:
3 years, 11 months ago
Reviewers:
kojii, eae
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start documentation of text stack in platform/fonts Move existing description of HarfBuzzShaper internals into shaping section, add outline of other essential text stack functionality. Committed: https://crrev.com/56280ba97a922dce483b5b99c446888cbdc5d90e Cr-Commit-Position: refs/heads/master@{#440954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -82 lines) Patch
A third_party/WebKit/Source/platform/fonts/README.md View 1 chunk +137 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
drott
3 years, 11 months ago (2016-12-28 18:43:49 UTC) #4
drott
Are you in the office today, Koji? Thanks for taking a look in advance.
3 years, 11 months ago (2016-12-29 09:08:09 UTC) #9
kojii
This is great, lgtm
3 years, 11 months ago (2016-12-29 12:16:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601953002/1
3 years, 11 months ago (2016-12-29 13:44:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 13:48:08 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:13 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56280ba97a922dce483b5b99c446888cbdc5d90e
Cr-Commit-Position: refs/heads/master@{#440954}

Powered by Google App Engine
This is Rietveld 408576698