[ios] Stop setting omnibox fakebox flag on iPhone.

[ios] Stop setting omnibox fakebox flag on iPhone.

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible on iPhone, we don't need the fakebox flag.

BUG=666081
Review-Url: https://codereview.chromium.org/2601943002
Cr-Commit-Position: refs/heads/master@{#443292}
Committed: https://chromium.googlesource.com/chromium/src/+/6d6c1221c00cad25be19f8cf94cc3e0ac0030638

[justincohen, 2016-12-28 18:17:59]

justincohen@chromium.org changed reviewers:
+ mpearson@google.com, rohitrao@chromium.org

[justincohen, 2016-12-28 18:17:59]

PTAL

[rohitrao (ping after 24h), 2017-01-03 14:13:01]

Updated the bug as well, but do we want to keep the existing behavior on tablet,
where we have two boxes on the NTP?

[justincohen, 2017-01-08 22:49:50]

ptal

[justincohen, 2017-01-08 22:50:04]

Description was changed from

==========
[ios] Stop setting omnibox fakebox flag.

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible, we don't need the fakebox flag.

BUG=666081
==========

to

==========
[ios] Stop setting omnibox fakebox flag on iPhone.

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible on iPhone, we don't need the fakebox
flag.

BUG=666081
==========

[rohitrao (ping after 24h), 2017-01-10 17:18:45]

lgtm

https://codereview.chromium.org/2601943002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2601943002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1342: //
SetCaretVisibility is a no-op unless OnSetFocus is called first.
Add to this explaining why the phone omnibox does not count as a fakebox?

[justincohen, 2017-01-12 18:04:23]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2017-01-12 18:04:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2601943002/#ps40001
(title: "Update comment")

[justincohen, 2017-01-12 18:04:36]

https://codereview.chromium.org/2601943002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2601943002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:1342: //
SetCaretVisibility is a no-op unless OnSetFocus is called first.
On 2017/01/10 17:18:45, rohitrao wrote:
> Add to this explaining why the phone omnibox does not count as a fakebox?

Done.

[commit-bot: I haz the power, 2017-01-12 18:05:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:16:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484244263132680,
"parent_rev": "525d6e76600f29e2f724f29584129fec46236641", "commit_rev":
"6d6c1221c00cad25be19f8cf94cc3e0ac0030638"}

[commit-bot: I haz the power, 2017-01-12 18:16:47]

Description was changed from

==========
[ios] Stop setting omnibox fakebox flag on iPhone.

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible on iPhone, we don't need the fakebox
flag.

BUG=666081
==========

to

==========
[ios] Stop setting omnibox fakebox flag on iPhone.

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible on iPhone, we don't need the fakebox
flag.

BUG=666081

Review-Url: https://codereview.chromium.org/2601943002
Cr-Commit-Position: refs/heads/master@{#443292}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d6c1221c00cad25be19f8cf94cc...
==========

[commit-bot: I haz the power, 2017-01-12 18:16:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6d6c1221c00cad25be19f8cf94cc...