Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2601933002: Always show login header bar on the account picker screen. (Closed)

Created:
3 years, 11 months ago by Roman Sorokin (ftl)
Modified:
3 years, 11 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always show login header bar on the account picker screen. BUG=677275 TEST=manual Committed: https://crrev.com/ea8cdf9fa1b6d55b512d6ce9e8a67a5a0c7b836c Cr-Commit-Position: refs/heads/master@{#440944}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rewrite the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/login/account_picker/screen_account_picker.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Roman Sorokin (ftl)
Alex, PTAL. Thanks!
3 years, 11 months ago (2016-12-28 14:46:56 UTC) #4
Alexander Alekseev
lgtm with nits. https://codereview.chromium.org/2601933002/diff/1/ui/login/account_picker/screen_account_picker.js File ui/login/account_picker/screen_account_picker.js (right): https://codereview.chromium.org/2601933002/diff/1/ui/login/account_picker/screen_account_picker.js#newcode121 ui/login/account_picker/screen_account_picker.js:121: // Button header is always visible ...
3 years, 11 months ago (2016-12-28 18:04:17 UTC) #7
Alexander Alekseev
lgtm with nits.
3 years, 11 months ago (2016-12-28 18:04:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601933002/20001
3 years, 11 months ago (2016-12-29 06:57:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-29 07:09:03 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea8cdf9fa1b6d55b512d6ce9e8a67a5a0c7b836c
Cr-Commit-Position: refs/heads/master@{#440944}

Powered by Google App Engine
This is Rietveld 408576698