Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2601923003: [css-tables] Fix caret position inside empty cell (Closed)

Created:
3 years, 11 months ago by Manuel Rego
Modified:
3 years, 11 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-tables] Fix caret position inside empty cell Override hasLineIfEmpty() in LayoutTableCell to consider that it has an empty line if it's editable. This fixes the position of the caret in empty cells, that was painted lower than expected (and then modified when you start to edit the cell). BUG=421716 TEST=editing/caret/caret-in-empty-cell.html Committed: https://crrev.com/1a4e384d607b15a408bbd7b9e6f3528fb2cc8e30 Cr-Commit-Position: refs/heads/master@{#441101}

Patch Set 1 #

Patch Set 2 : Test rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -63 lines) Patch
A third_party/WebKit/LayoutTests/editing/caret/caret-in-empty-cell.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/caret/caret-in-empty-cell-expected.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/5206311-2-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/5433862-1-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/image-set-value-not-removed-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/lists/remove-listmarker-and-make-anonblock-empty-2-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5126166-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5206311-1-expected.txt View 1 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5433862-2-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5483370-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/deleting/5483370-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5126166-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5206311-1-expected.txt View 1 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5433862-2-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5483370-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/deleting/5483370-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/deleting/5126166-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/deleting/5206311-1-expected.txt View 1 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/deleting/5433862-2-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/deleting/5483370-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/deleting/5483370-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Manuel Rego
3 years, 11 months ago (2016-12-29 10:41:39 UTC) #2
Manuel Rego
BTW, some tests are going to fail, I'm running the tryjobs to get the new ...
3 years, 11 months ago (2016-12-29 10:49:59 UTC) #3
eae
LGTM
3 years, 11 months ago (2017-01-02 18:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601923003/20001
3 years, 11 months ago (2017-01-03 08:27:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 10:15:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 10:18:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a4e384d607b15a408bbd7b9e6f3528fb2cc8e30
Cr-Commit-Position: refs/heads/master@{#441101}

Powered by Google App Engine
This is Rietveld 408576698