Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2070)

Unified Diff: ui/views/accessibility/native_view_accessibility_unittest.cc

Issue 2601883002: MacViews/a11y: Mark Views as invisible if their parents are invisible. (Closed)
Patch Set: Switch to View::IsDrawn(). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/accessibility/native_view_accessibility.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessibility/native_view_accessibility_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_unittest.cc b/ui/views/accessibility/native_view_accessibility_unittest.cc
index c75ae19e1d3ce103c3c77b5b02647d47da023cb0..a67884894f0c3d1d8181c29905a856b827560e69 100644
--- a/ui/views/accessibility/native_view_accessibility_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_unittest.cc
@@ -48,6 +48,7 @@ class NativeViewAccessibilityTest : public ViewsTestBase {
label_accessibility_ = NativeViewAccessibility::Create(label_);
widget_->GetContentsView()->AddChildView(button_);
+ widget_->Show();
}
void TearDown() override {
@@ -88,8 +89,21 @@ TEST_F(NativeViewAccessibilityTest, LabelIsChildOfButton) {
label_accessibility_->GetParent());
}
+// Verify Views with invisible ancestors have AX_STATE_INVISIBLE.
+TEST_F(NativeViewAccessibilityTest, InvisibleViews) {
+ EXPECT_TRUE(widget_->IsVisible());
+ EXPECT_FALSE(
+ button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+ EXPECT_FALSE(
+ label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+ button_->SetVisible(false);
+ EXPECT_TRUE(
+ button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+ EXPECT_TRUE(
+ label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+}
+
TEST_F(NativeViewAccessibilityTest, WritableFocus) {
- widget_->Show();
// Make |button_| focusable, and focus/unfocus it via NativeViewAccessibility.
button_->SetFocusBehavior(View::FocusBehavior::ALWAYS);
EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
« no previous file with comments | « ui/views/accessibility/native_view_accessibility.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698