MacViews/a11y: Mark Views as invisible if their parents are invisible.

ui/views/accessibility/native_view_accessibility_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/controls/button/button.h"
@@ skipping 30 matching lines @@
 
     button_ = new TestButton();
     button_->SetSize(gfx::Size(20, 20));
     button_accessibility_ = NativeViewAccessibility::Create(button_);
 
     label_ = new Label();
     button_->AddChildView(label_);
     label_accessibility_ = NativeViewAccessibility::Create(label_);
 
     widget_->GetContentsView()->AddChildView(button_);
+    widget_->Show();
   }
 
   void TearDown() override {
     if (!widget_->IsClosed())
       widget_->Close();
     button_accessibility_->Destroy();
     button_accessibility_ = NULL;
     label_accessibility_->Destroy();
     label_accessibility_ = NULL;
     ViewsTestBase::TearDown();
@@ skipping 20 matching lines @@
 }
 
 TEST_F(NativeViewAccessibilityTest, LabelIsChildOfButton) {
   EXPECT_EQ(1, button_accessibility_->GetChildCount());
   EXPECT_EQ(label_->GetNativeViewAccessible(),
             button_accessibility_->ChildAtIndex(0));
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             label_accessibility_->GetParent());
 }
 
+// Verify Views with invisible ancestors have AX_STATE_INVISIBLE.
+TEST_F(NativeViewAccessibilityTest, InvisibleViews) {
+  EXPECT_TRUE(widget_->IsVisible());
+  EXPECT_FALSE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_FALSE(
+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  button_->SetVisible(false);
+  EXPECT_TRUE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_TRUE(
+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+}
+
 TEST_F(NativeViewAccessibilityTest, WritableFocus) {
-  widget_->Show();
   // Make |button_| focusable, and focus/unfocus it via NativeViewAccessibility.
   button_->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(nullptr, button_accessibility_->GetFocus());
   EXPECT_TRUE(button_accessibility_->SetFocused(true));
   EXPECT_EQ(button_, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             button_accessibility_->GetFocus());
   EXPECT_TRUE(button_accessibility_->SetFocused(false));
   EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
@@ skipping 35 matching lines @@
   // WidgetObserver. Note that TestNativeViewAccessibility is a subclass
   // defined above that destroys itself when its parent widget is destroyed.
   TestNativeViewAccessibility* child_accessible =
       new TestNativeViewAccessibility(child_widget->GetRootView());
   child_accessible->SetParentWidget(parent_widget.get());
   parent_widget.reset();
 }
 
 }  // namespace test
 }  // namespace views