MacViews/a11y: Mark Views as invisible if their parents are invisible.

ui/views/accessibility/native_view_accessibility_unittest.cc

Index: ui/views/accessibility/native_view_accessibility_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_unittest.cc b/ui/views/accessibility/native_view_accessibility_unittest.cc
index c75ae19e1d3ce103c3c77b5b02647d47da023cb0..010ecdcbc8c8ec04817501eb302dd585871ac696 100644
--- a/ui/views/accessibility/native_view_accessibility_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_unittest.cc
@@ -88,6 +88,18 @@ TEST_F(NativeViewAccessibilityTest, LabelIsChildOfButton) {
             label_accessibility_->GetParent());
 }
 
+TEST_F(NativeViewAccessibilityTest, InvisibleViews) {

[karandeepb, 2016/12/28 10:57:10]

Doesn't this first require widget_->Show() or is the widget already visible? You
can probably start with EXPECT_TRUE(widget_->IsVisible()).

Also, you can probably add a comment for the test like - Verify views with
invisible ancestors have AX_STATE_INVISIBLE even if View::visible() returns true
for them.

[Patti Lor, 2016/12/29 00:57:56]

It seems to work still even when the widget is invisible, which also seems a bit
weird to me :S Added widget_->Show() to SetUp(), plus your IsVisible()
suggestion and the comment as well. I left out the bit about View::visible
returning true because it's an implementation detail the test doesn't really
need to know about.

[karandeepb, 2016/12/29 09:36:16]

Weird! 

+  EXPECT_FALSE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_FALSE(
+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  button_->SetVisible(false);
+  EXPECT_TRUE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_TRUE(

[karandeepb, 2016/12/28 10:57:10]

I believe this is FALSE currently, which this CL corrects?

[Patti Lor, 2016/12/29 00:57:56]

Yep! Have checked it fails without changes to native_view_accessibility.cc.

+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+}
+
 TEST_F(NativeViewAccessibilityTest, WritableFocus) {
   widget_->Show();
   // Make |button_| focusable, and focus/unfocus it via NativeViewAccessibility.