MacViews/a11y: Mark Views as invisible if their parents are invisible.

ui/views/accessibility/native_view_accessibility_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/controls/button/button.h"
@@ skipping 70 matching lines @@
 }
 
 TEST_F(NativeViewAccessibilityTest, LabelIsChildOfButton) {
   EXPECT_EQ(1, button_accessibility_->GetChildCount());
   EXPECT_EQ(label_->GetNativeViewAccessible(),
             button_accessibility_->ChildAtIndex(0));
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             label_accessibility_->GetParent());
 }
 
+TEST_F(NativeViewAccessibilityTest, InvisibleViews) {

[karandeepb, 2016/12/28 10:57:10]

Doesn't this first require widget_->Show() or is the widget already visible? You
can probably start with EXPECT_TRUE(widget_->IsVisible()).

Also, you can probably add a comment for the test like - Verify views with
invisible ancestors have AX_STATE_INVISIBLE even if View::visible() returns true
for them.

[Patti Lor, 2016/12/29 00:57:56]

It seems to work still even when the widget is invisible, which also seems a bit
weird to me :S Added widget_->Show() to SetUp(), plus your IsVisible()
suggestion and the comment as well. I left out the bit about View::visible
returning true because it's an implementation detail the test doesn't really
need to know about.

[karandeepb, 2016/12/29 09:36:16]

Weird! 

+  EXPECT_FALSE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_FALSE(
+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  button_->SetVisible(false);
+  EXPECT_TRUE(
+      button_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+  EXPECT_TRUE(

[karandeepb, 2016/12/28 10:57:10]

I believe this is FALSE currently, which this CL corrects?

[Patti Lor, 2016/12/29 00:57:56]

Yep! Have checked it fails without changes to native_view_accessibility.cc.

+      label_accessibility_->GetData().HasStateFlag(ui::AX_STATE_INVISIBLE));
+}
+
 TEST_F(NativeViewAccessibilityTest, WritableFocus) {
   widget_->Show();
   // Make |button_| focusable, and focus/unfocus it via NativeViewAccessibility.
   button_->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(nullptr, button_accessibility_->GetFocus());
   EXPECT_TRUE(button_accessibility_->SetFocused(true));
   EXPECT_EQ(button_, button_->GetFocusManager()->GetFocusedView());
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             button_accessibility_->GetFocus());
@@ skipping 37 matching lines @@
   // WidgetObserver. Note that TestNativeViewAccessibility is a subclass
   // defined above that destroys itself when its parent widget is destroyed.
   TestNativeViewAccessibility* child_accessible =
       new TestNativeViewAccessibility(child_widget->GetRootView());
   child_accessible->SetParentWidget(parent_widget.get());
   parent_widget.reset();
 }
 
 }  // namespace test
 }  // namespace views