Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2601853002: Revert of Fixed a bug where chrome crash omits crash time stamp after it's sent. (Closed)

Created:
3 years, 11 months ago by Wez
Modified:
3 years, 11 months ago
Reviewers:
Robert Sesek, Jia, opp90350
CC:
chromium-reviews, kalyank, sadrul, napper, PhistucK
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed a bug where chrome crash omits crash time stamp after it's sent. (patchset #1 id:1 of https://codereview.chromium.org/2568953003/ ) Reason for revert: See crbug.com/674249: This change broke things in two ways: - The string format incorrectly uses the crash-time parameter twice, rather than the second parameter coming from upload-time. - The string format assumes that all crashes have a valid crash-time, which is not the case for Breakpad reports. Original issue's description: > Fixed a bug where chrome crash omits crash time stamp after it's sent. > > This cl patches in the solution devised by phistuck@gmail.com. See bug 664430 for detail. > > BUG=664430 > > Committed: https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5 > Cr-Commit-Position: refs/heads/master@{#438333} TBR=rsesek@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664430 Committed: https://crrev.com/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4 Cr-Commit-Position: refs/heads/master@{#440801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/crash/core/browser/crashes_ui_util.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/crash/core/browser/resources/crashes.js View 1 chunk +1 line, -2 lines 0 comments Download
M components/crash_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Wez
Created Revert of Fixed a bug where chrome crash omits crash time stamp after it's ...
3 years, 11 months ago (2016-12-27 22:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601853002/1
3 years, 11 months ago (2016-12-27 22:28:44 UTC) #3
Wez
FYI, reverting the first change, so we can fix the issues and re-land shortly.
3 years, 11 months ago (2016-12-27 22:32:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-27 23:15:36 UTC) #8
opp90350
3 years, 11 months ago (2016-12-28 10:12:35 UTC) #10
opp90350
lgtm
3 years, 11 months ago (2016-12-28 10:12:37 UTC) #11
opp90350
lgtm
3 years, 11 months ago (2016-12-28 10:12:38 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4
Cr-Commit-Position: refs/heads/master@{#440801}

Powered by Google App Engine
This is Rietveld 408576698