Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: content/test/content_browser_test_utils_internal.h

Issue 2601843002: Convert more test helpers to base::RunLoop, fix page title checks. (Closed)
Patch Set: Remove unneeded call. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/content_browser_test_utils_internal.h
diff --git a/content/test/content_browser_test_utils_internal.h b/content/test/content_browser_test_utils_internal.h
index 1ff94ab0e03053e2b9eb27a84f7eade9527a87c8..52227f73c446f26d55f6ced141a10ee0ec41b1f9 100644
--- a/content/test/content_browser_test_utils_internal.h
+++ b/content/test/content_browser_test_utils_internal.h
@@ -16,6 +16,7 @@
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "base/run_loop.h"
#include "cc/surfaces/surface_id.h"
#include "content/public/browser/resource_dispatcher_host_delegate.h"
#include "content/public/browser/web_contents_delegate.h"
@@ -30,7 +31,6 @@ class SurfaceManager;
namespace content {
class FrameTreeNode;
-class MessageLoopRunner;
class RenderFrameHost;
class RenderWidgetHostViewChildFrame;
class Shell;
@@ -198,8 +198,8 @@ class UrlCommitObserver : WebContentsObserver {
// The URL this observer is expecting to be committed.
GURL url_;
- // The MessageLoopRunner used to spin the message loop.
- scoped_refptr<MessageLoopRunner> message_loop_runner_;
+ // The RunLoop used to spin the message loop.
+ base::RunLoop run_loop_;
DISALLOW_COPY_AND_ASSIGN(UrlCommitObserver);
};

Powered by Google App Engine
This is Rietveld 408576698