Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: content/test/content_browser_test_utils_internal.cc

Issue 2601843002: Convert more test helpers to base::RunLoop, fix page title checks. (Closed)
Patch Set: Remove unneeded call. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/content_browser_test_utils_internal.cc
diff --git a/content/test/content_browser_test_utils_internal.cc b/content/test/content_browser_test_utils_internal.cc
index 392439525ba2bc8451d4dc5720447e0382d6d94b..4d9423057b83a7d01095fafc450eaf6042d02cb5 100644
--- a/content/test/content_browser_test_utils_internal.cc
+++ b/content/test/content_browser_test_utils_internal.cc
@@ -378,15 +378,13 @@ UrlCommitObserver::UrlCommitObserver(FrameTreeNode* frame_tree_node,
->delegate()
->GetAsWebContents()),
frame_tree_node_id_(frame_tree_node->frame_tree_node_id()),
- url_(url),
- message_loop_runner_(
- new MessageLoopRunner(MessageLoopRunner::QuitMode::IMMEDIATE)) {
+ url_(url) {
}
UrlCommitObserver::~UrlCommitObserver() {}
void UrlCommitObserver::Wait() {
- message_loop_runner_->Run();
+ run_loop_.Run();
}
void UrlCommitObserver::DidFinishNavigation(
@@ -395,7 +393,7 @@ void UrlCommitObserver::DidFinishNavigation(
!navigation_handle->IsErrorPage() &&
navigation_handle->GetURL() == url_ &&
navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) {
- message_loop_runner_->Quit();
+ run_loop_.Quit();
}
}

Powered by Google App Engine
This is Rietveld 408576698