Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2601773005:
Use testing SafeBrowsingService for activation in SubresourceFilterBrowserTest. (Closed)
DescriptionUse a TestSafeBrowsingService for activation in SubresourceFilter browsertests.
Instead of blanket activation, bring the tests closer to reality by setting the
subresource filtering in `activation list` mode, and bringing up a
TestSafeBrowsingService, which allows the tests to artificially mark URLs as
blacklisted, and thus allows the subresource filtering logic to receive an
activation signal when these URLs are navigated to in the main frame.
The CL also changes the test to trigger same-page navigations from the renderer
side, to prevent WebContentsObservers seeing duplicate (nested) navigations
when browser-side navigation is enabled.
BUG=637415
Committed: https://crrev.com/b15e86870a58be9115d5cc0afafc4512665af6c0
Cr-Commit-Position: refs/heads/master@{#440952}
Patch Set 1 #Patch Set 2 : Fix includes. #Patch Set 3 : Investigate linux try failure. #Patch Set 4 : Rebase. #Patch Set 5 : Fix browser-side navigation tests. #Messages
Total messages: 25 (19 generated)
Description was changed from ========== Use testing SafeBrowsingService for activation in SubresourceFilterBrowserTest. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService to provide the activation signal by allowing the tests to mark URLs as blacklisted as desired. BUG=637415 ========== to ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and then sends the activation signal when these URLs are navigated to in the main frame. BUG=637415 ==========
engedy@chromium.org changed reviewers: + melandory@chromium.org
Description was changed from ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and then sends the activation signal when these URLs are navigated to in the main frame. BUG=637415 ========== to ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. BUG=637415 ==========
Tanja, could you please take a look?
The CQ bit was checked by engedy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/28 12:56:09, engedy wrote: > Tanja, could you please take a look? lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by engedy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by engedy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from melandory@chromium.org Link to the patchset: https://codereview.chromium.org/2601773005/#ps80001 (title: "Fix browser-side navigation tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. BUG=637415 ========== to ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. The CL also changes the test to trigger same-page navigations from the renderer side, to prevent WebContentsObservers seeing duplicate (nested) navigations when browser-side navigation is enabled. BUG=637415 ==========
The CQ bit was unchecked by engedy@chromium.org
The CQ bit was checked by engedy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483014948793200,
"parent_rev": "1ce61f5e9461f940c3b847e03cba2eac567a72bb", "commit_rev":
"10c5153d6ab2c57b18f73d978625e29fdd0cca21"}
Message was sent while issue was closed.
Description was changed from ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. The CL also changes the test to trigger same-page navigations from the renderer side, to prevent WebContentsObservers seeing duplicate (nested) navigations when browser-side navigation is enabled. BUG=637415 ========== to ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. The CL also changes the test to trigger same-page navigations from the renderer side, to prevent WebContentsObservers seeing duplicate (nested) navigations when browser-side navigation is enabled. BUG=637415 Review-Url: https://codereview.chromium.org/2601773005 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. The CL also changes the test to trigger same-page navigations from the renderer side, to prevent WebContentsObservers seeing duplicate (nested) navigations when browser-side navigation is enabled. BUG=637415 Review-Url: https://codereview.chromium.org/2601773005 ========== to ========== Use a TestSafeBrowsingService for activation in SubresourceFilter browsertests. Instead of blanket activation, bring the tests closer to reality by setting the subresource filtering in `activation list` mode, and bringing up a TestSafeBrowsingService, which allows the tests to artificially mark URLs as blacklisted, and thus allows the subresource filtering logic to receive an activation signal when these URLs are navigated to in the main frame. The CL also changes the test to trigger same-page navigations from the renderer side, to prevent WebContentsObservers seeing duplicate (nested) navigations when browser-side navigation is enabled. BUG=637415 Committed: https://crrev.com/b15e86870a58be9115d5cc0afafc4512665af6c0 Cr-Commit-Position: refs/heads/master@{#440952} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b15e86870a58be9115d5cc0afafc4512665af6c0 Cr-Commit-Position: refs/heads/master@{#440952} |
