Adding check for team and component tags in owners files.

Adding check for team and component tags in owners files.

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954
Review-Url: https://codereview.chromium.org/2601773004
Committed: https://chromium.googlesource.com/chromium/src/+/9b21c11aaa6ad0e4d5bc0cd6e750b67e86ad0fbc

[RobertoCN, 2016-12-28 00:38:02]

PTAL

[Paweł Hajdan Jr., 2016-12-28 08:43:04]

LGTM w/comments

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
File tools/checkteamtags/checkteamtags.py (right):

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
tools/checkteamtags/checkteamtags.py:32: if os.path.exists(full_path):
Do we make it a silent error if full_path doesn't exist?

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
tools/checkteamtags/checkteamtags.py:33: owners_file_lines =
open(full_path).readlines()
nit: Consider using "with" so that we close the file.

[RobertoCN, 2016-12-28 21:47:10]

I addressed Paweł's comments and added some unit tests.

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
File tools/checkteamtags/checkteamtags.py (right):

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
tools/checkteamtags/checkteamtags.py:32: if os.path.exists(full_path):
On 2016/12/28 08:43:04, Paweł Hajdan Jr. wrote:
> Do we make it a silent error if full_path doesn't exist?

We shouldn't. If this were to fail, then something else is wrong. I am removing
the check to let any failure bubble up.

https://codereview.chromium.org/2601773004/diff/1/tools/checkteamtags/checkte...
tools/checkteamtags/checkteamtags.py:33: owners_file_lines =
open(full_path).readlines()
On 2016/12/28 08:43:04, Paweł Hajdan Jr. wrote:
> nit: Consider using "with" so that we close the file.

Done.

[stgao, 2017-01-03 22:47:00]

lgtm with nits.

https://codereview.chromium.org/2601773004/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/20001/PRESUBMIT.py#newcode755
PRESUBMIT.py:755: """Check that OWNERS files have consistent TEAM and COMPONENT
tags."""
nit: Check -> Checks

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/OWNERS
File tools/checkteamtags/OWNERS (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/OWN...
tools/checkteamtags/OWNERS:2: robertocn@chromium.org
nit: switch to be in alphabet order?

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/PRE...
File tools/checkteamtags/PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/PRE...
tools/checkteamtags/PRESUBMIT.py:1: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
nit: 2013 -> 2016/2017?

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
File tools/checkteamtags/checkteamtags.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
tools/checkteamtags/checkteamtags.py:77: help='Specifies the repository root.')
nit: fit in last line.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
File tools/checkteamtags/checkteamtags_test.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
tools/checkteamtags/checkteamtags_test.py:54: # TEAM: some-team@chromium.org
some-other-team@chromium.org
Similar to this one, should we also check the case below?

# COMPONENT: Blink>mock_component, V8>mock_component
# COMPONENT: Blink>mock_component V8>mock_component

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/run...
File tools/checkteamtags/run_tests (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/run...
tools/checkteamtags/run_tests:2: # Copyright 2014 The Chromium Authors. All
rights reserved.
nit: 2014 -> 2016/2017.

If we go with 2017, we need to update 2016 -> 2017 in other new files too.

[RobertoCN, 2017-01-04 00:17:46]

PTAL, added check against multiple components in one line.

[Dirk Pranke, 2017-01-04 03:11:49]

I defer to phajdan.jr here.

[stgao, 2017-01-04 06:35:27]

lgtm with one more comment.

https://codereview.chromium.org/2601773004/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/40001/PRESUBMIT.py#newcode762
PRESUBMIT.py:762: if input_api.os_path.basename(f.AbsoluteLocalPath()) ==
'OWNERS']
Just double check: will this also work for Windows? On windows, file path is
case-insensitive.
To be safe, it might be better to compare both in upper case.

[RobertoCN, 2017-01-04 18:48:59]

https://codereview.chromium.org/2601773004/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/20001/PRESUBMIT.py#newcode755
PRESUBMIT.py:755: """Check that OWNERS files have consistent TEAM and COMPONENT
tags."""
On 2017/01/03 22:46:59, stgao (slow on Monday) wrote:
> nit: Check -> Checks

Done.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/OWNERS
File tools/checkteamtags/OWNERS (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/OWN...
tools/checkteamtags/OWNERS:2: robertocn@chromium.org
On 2017/01/03 22:46:59, stgao (slow on Monday) wrote:
> nit: switch to be in alphabet order?

Done.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/PRE...
File tools/checkteamtags/PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/PRE...
tools/checkteamtags/PRESUBMIT.py:1: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
On 2017/01/03 22:46:59, stgao (slow on Monday) wrote:
> nit: 2013 -> 2016/2017?

Done.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
File tools/checkteamtags/checkteamtags.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
tools/checkteamtags/checkteamtags.py:77: help='Specifies the repository root.')
On 2017/01/03 22:46:59, stgao (slow on Monday) wrote:
> nit: fit in last line.

Done.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
File tools/checkteamtags/checkteamtags_test.py (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/che...
tools/checkteamtags/checkteamtags_test.py:54: # TEAM: some-team@chromium.org
some-other-team@chromium.org
On 2017/01/03 22:46:59, stgao (slow on Monday) wrote:
> Similar to this one, should we also check the case below?
> 
> # COMPONENT: Blink>mock_component, V8>mock_component
> # COMPONENT: Blink>mock_component V8>mock_component

Done.

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/run...
File tools/checkteamtags/run_tests (right):

https://codereview.chromium.org/2601773004/diff/20001/tools/checkteamtags/run...
tools/checkteamtags/run_tests:2: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2017/01/03 22:47:00, stgao (slow on Monday) wrote:
> nit: 2014 -> 2016/2017.
> 
> If we go with 2017, we need to update 2016 -> 2017 in other new files too.

Done.

https://codereview.chromium.org/2601773004/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2601773004/diff/40001/PRESUBMIT.py#newcode762
PRESUBMIT.py:762: if input_api.os_path.basename(f.AbsoluteLocalPath()) ==
'OWNERS']
On 2017/01/04 06:35:27, stgao (slow on Monday) wrote:
> Just double check: will this also work for Windows? On windows, file path is
> case-insensitive.
> To be safe, it might be better to compare both in upper case.

Done.

[RobertoCN, 2017-01-04 18:49:04]

The CQ bit was checked by robertocn@chromium.org

[RobertoCN, 2017-01-04 18:49:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2601773004/#ps60001
(title: "Addressing last comment.")

[commit-bot: I haz the power, 2017-01-04 18:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:01:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483555744556100,
"parent_rev": "c59783e9c36c5b5d18b8980c2e6efafaa78433a8", "commit_rev":
"9b21c11aaa6ad0e4d5bc0cd6e750b67e86ad0fbc"}

[commit-bot: I haz the power, 2017-01-04 19:03:46]

Description was changed from

==========
Adding check for team and component tags in owners files.

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954
==========

to

==========
Adding check for team and component tags in owners files.

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954

Committed: https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d
Cr-Commit-Position: refs/heads/master@{#441420}
==========

[commit-bot: I haz the power, 2017-01-04 19:03:47]

Patchset 4 (id:??) landed as
https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d
Cr-Commit-Position: refs/heads/master@{#441420}

[commit-bot: I haz the power, 2017-01-04 19:04:05]

Description was changed from

==========
Adding check for team and component tags in owners files.

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954

Committed: https://crrev.com/832f59964c871959a85b6b64fb2ae81dc5e6441d
Cr-Commit-Position: refs/heads/master@{#441420}
==========

to

==========
Adding check for team and component tags in owners files.

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954

Review-Url: https://codereview.chromium.org/2601773004
Committed:
https://chromium.googlesource.com/chromium/src/+/9b21c11aaa6ad0e4d5bc0cd6e750...
==========

[commit-bot: I haz the power, 2017-01-04 19:04:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9b21c11aaa6ad0e4d5bc0cd6e750...