Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2601773003:
Fix the logic of counting the number of devices for Web Bluetooth chooser UMA (Closed)
DescriptionFix the logic of counting the number of devices for Web Bluetooth chooser UMA
This is a follow-up CL for
https://codereview.chromium.org/2577183002/
This CL fixes the logic of counting the number of devices. Previously, the
|device_ids_| is cleared in function StartDeviceDiscovery(), and since
StartDeviceDiscovery() is called after PopulateConnectedDevices(),
and PopulateConnectedDevices() may add cached devices. So those added devices
are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_|
before the PopulateConnectedDevices() function is called.
TBR=scheib@chromium.org
BUG=674195
Committed: https://crrev.com/41105d8a7831fff4df07939b32330445cce21a95
Cr-Commit-Position: refs/heads/master@{#440781}
Patch Set 1 : fix the logic of counting the number of devices for Web Bluetooth chooser UMA #
Messages
Total messages: 15 (11 generated)
The CQ bit was checked by juncai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is only cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices() function, and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ========== to ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is only cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices() function, and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ==========
Description was changed from ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is only cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices() function, and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ========== to ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices() function, and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ==========
Description was changed from ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices() function, and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ========== to ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices(), and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by juncai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482870504805980, "parent_rev":
"813b5cede9c6a297e00c43231669396f173eed0a", "commit_rev":
"3476d5e5fbb1dfb03cb3b10ad6bda61eb9b3a2a0"}
Message was sent while issue was closed.
Description was changed from ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices(), and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 ========== to ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices(), and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 Review-Url: https://codereview.chromium.org/2601773003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices(), and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 Review-Url: https://codereview.chromium.org/2601773003 ========== to ========== Fix the logic of counting the number of devices for Web Bluetooth chooser UMA This is a follow-up CL for https://codereview.chromium.org/2577183002/ This CL fixes the logic of counting the number of devices. Previously, the |device_ids_| is cleared in function StartDeviceDiscovery(), and since StartDeviceDiscovery() is called after PopulateConnectedDevices(), and PopulateConnectedDevices() may add cached devices. So those added devices are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_| before the PopulateConnectedDevices() function is called. TBR=scheib@chromium.org BUG=674195 Committed: https://crrev.com/41105d8a7831fff4df07939b32330445cce21a95 Cr-Commit-Position: refs/heads/master@{#440781} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/41105d8a7831fff4df07939b32330445cce21a95 Cr-Commit-Position: refs/heads/master@{#440781}
Message was sent while issue was closed.
LGTM |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
