Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2601613002: Show an info icon with a tooltip for PSL-matches in the account chooser on Mac. (Closed)

Created:
3 years, 12 months ago by vasilii
Modified:
3 years, 12 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show an info icon with a tooltip for PSL-matches in the account chooser on Mac. The screenshots are attached to the bug. BUG=666340 Committed: https://crrev.com/0e67335f4b7a36e8e64735e6fb1cf81da6e9376e Cr-Commit-Position: refs/heads/master@{#440630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 3 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/credential_item_button.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vasilii
Hi Vaclav, please review.
3 years, 12 months ago (2016-12-23 14:10:50 UTC) #4
vabr (Chromium)
LGTM, thanks for providing the screenshots as well. Cheers, Vaclav
3 years, 12 months ago (2016-12-23 14:16:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601613002/1
3 years, 12 months ago (2016-12-23 14:17:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-23 14:48:25 UTC) #11
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 14:50:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e67335f4b7a36e8e64735e6fb1cf81da6e9376e
Cr-Commit-Position: refs/heads/master@{#440630}

Powered by Google App Engine
This is Rietveld 408576698