Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2601583002: Butler: fix global tags applied to empty map. (Closed)

Created:
3 years, 12 months ago by dnj
Modified:
3 years, 12 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added tests, testing method to Bundler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
M logdog/client/butler/bundler/bundler.go View 1 2 chunks +21 lines, -0 lines 0 comments Download
M logdog/client/butler/bundler/stream.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M logdog/client/butler/butler.go View 1 chunk +4 lines, -0 lines 0 comments Download
M logdog/client/butler/butler_test.go View 1 2 chunks +60 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dnj
3 years, 12 months ago (2016-12-22 22:58:30 UTC) #1
seanmccullough1
lgtm tests?
3 years, 12 months ago (2016-12-22 23:02:26 UTC) #3
dnj
kk added tests
3 years, 12 months ago (2016-12-22 23:26:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601583002/20001
3 years, 12 months ago (2016-12-22 23:26:15 UTC) #7
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 23:32:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6eccb06f2227ce46fdabf854eb526d10f6878efe

Powered by Google App Engine
This is Rietveld 408576698