Fix crashes when FileWriter methods are called after context is destroyed.

Fix crashes when FileWriter methods are called after context is destroyed.

In r439956 FileWriter was changed to reset writer() when the context is
destroyed, but that meant that now calling any of its methods after the
context was destroyed would crash. This fixes that by making sure the
context is still alive when any of its javascript methods are called.

BUG=676407
BUG=656453
Committed: https://crrev.com/2726ac3437f9524bc027021f672bb69a343cc69a
Cr-Commit-Position: refs/heads/master@{#440465}

[Marijn Kruisselbrink, 2016-12-22 17:57:05]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-12-22 17:57:34]

mek@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org

[haraken, 2016-12-22 18:01:39]

LGTM

[haraken, 2016-12-22 18:01:55]

Or you can check if(!m_writer). Either is fine.

[Marijn Kruisselbrink, 2016-12-22 18:57:20]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2016-12-22 18:57:22]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-12-22 18:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 19:17:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482433042610270, "parent_rev":
"07d9044784463b01dc04dd2a9ba219975d178673", "commit_rev":
"23f5af6fdb32895979eb0ccddabd2ddb99c3dbc3"}

[commit-bot: I haz the power, 2016-12-22 19:17:45]

Description was changed from

==========
Fix crashes when FileWriter methods are called after context is destroyed.

In r439956 FileWriter was changed to reset writer() when the context is
destroyed, but that meant that now calling any of its methods after the
context was destroyed would crash. This fixes that by making sure the
context is still alive when any of its javascript methods are called.

BUG=676407
BUG=656453
==========

to

==========
Fix crashes when FileWriter methods are called after context is destroyed.

In r439956 FileWriter was changed to reset writer() when the context is
destroyed, but that meant that now calling any of its methods after the
context was destroyed would crash. This fixes that by making sure the
context is still alive when any of its javascript methods are called.

BUG=676407
BUG=656453

Review-Url: https://codereview.chromium.org/2601543002
==========

[commit-bot: I haz the power, 2016-12-22 19:17:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 19:19:31]

Description was changed from

==========
Fix crashes when FileWriter methods are called after context is destroyed.

In r439956 FileWriter was changed to reset writer() when the context is
destroyed, but that meant that now calling any of its methods after the
context was destroyed would crash. This fixes that by making sure the
context is still alive when any of its javascript methods are called.

BUG=676407
BUG=656453

Review-Url: https://codereview.chromium.org/2601543002
==========

to

==========
Fix crashes when FileWriter methods are called after context is destroyed.

In r439956 FileWriter was changed to reset writer() when the context is
destroyed, but that meant that now calling any of its methods after the
context was destroyed would crash. This fixes that by making sure the
context is still alive when any of its javascript methods are called.

BUG=676407
BUG=656453

Committed: https://crrev.com/2726ac3437f9524bc027021f672bb69a343cc69a
Cr-Commit-Position: refs/heads/master@{#440465}
==========

[commit-bot: I haz the power, 2016-12-22 19:19:32]

Patchset 1 (id:??) landed as
https://crrev.com/2726ac3437f9524bc027021f672bb69a343cc69a
Cr-Commit-Position: refs/heads/master@{#440465}

[kinuko, 2016-12-27 01:39:34]

Thanks for fixing, belated lgtm