MacViews: Mark key down event as handled when consumed by the IME.

MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods.

BUG=676615
Committed: https://crrev.com/85d9c68076c03f77b7c61a9c2e2056862bb9d189
Cr-Commit-Position: refs/heads/master@{#440483}

[karandeepb, 2016-12-22 15:42:00]

Description was changed from

==========
--

BUG=
==========

to

==========
MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods. 

BUG=676615
==========

[karandeepb, 2016-12-22 15:45:40]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 15:45:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-12-22 15:49:03]

karandeepb@chromium.org changed reviewers:
+ avi@chromium.org

[karandeepb, 2016-12-22 15:49:04]

PTAL avi@. Can you review this since tapted@ is OOO. Have cc'd him on the CL.

[themblsha, 2016-12-22 16:21:32]

These two are invoked via -doCommandBySelector:? LGTM.

[commit-bot: I haz the power, 2016-12-22 16:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 16:36:40]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-12-22 19:43:14]

lgtm

[karandeepb, 2016-12-22 20:03:49]

On 2016/12/22 16:21:32, themblsha wrote:
> These two are invoked via -doCommandBySelector:? LGTM.

No they are invoked directly from interpretKeyEvents: w/o doCommandBySelector:
being called.

[karandeepb, 2016-12-22 20:04:30]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:04:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 20:08:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482437070463560, "parent_rev":
"d777029e2479eab595c0f245f20341324ac41848", "commit_rev":
"859586344f1f4d9325d90fbc5a6b93660074e576"}

[commit-bot: I haz the power, 2016-12-22 20:08:50]

Description was changed from

==========
MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods. 

BUG=676615
==========

to

==========
MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods. 

BUG=676615

Review-Url: https://codereview.chromium.org/2601513002
==========

[commit-bot: I haz the power, 2016-12-22 20:08:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 20:11:43]

Description was changed from

==========
MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods. 

BUG=676615

Review-Url: https://codereview.chromium.org/2601513002
==========

to

==========
MacViews: Mark key down event as handled when consumed by the IME.

r434436 changed how key events are handled on MacViews. It overrode
_wantsKeyDownForEvent: to receive more key events from Cocoa and passed all
unhandled key down events to the underlying views::Widget. However, key down
events captured by the IME in the following NSTextInputClient methods were not
marked as handled:
  - setMarkedText:selectedRange:replacementRange:
  - unmarkText:
As a result, these key down events were erronously passed to the underlying
views::Widget resulting in a regression in the IME behavior.

This CL fixes the regression by marking the key down event as handled in the
above mentioned methods.

BUG=676615

Committed: https://crrev.com/85d9c68076c03f77b7c61a9c2e2056862bb9d189
Cr-Commit-Position: refs/heads/master@{#440483}
==========

[commit-bot: I haz the power, 2016-12-22 20:11:44]

Patchset 1 (id:??) landed as
https://crrev.com/85d9c68076c03f77b7c61a9c2e2056862bb9d189
Cr-Commit-Position: refs/heads/master@{#440483}