Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2601493002: Remove an unnecessary copy of SSLCertRequestInfo data. (Closed)

Created:
4 years ago by davidben
Modified:
3 years, 11 months ago
Reviewers:
svaldez
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unnecessary copy of SSLCertRequestInfo data. Rather than have an extra copy of the data hanging off the SSLClientSocketImpl, we can extract it out of BoringSSL on demand. BUG=none Review-Url: https://codereview.chromium.org/2601493002 Cr-Commit-Position: refs/heads/master@{#443267} Committed: https://chromium.googlesource.com/chromium/src/+/b11fd211f55e332520f82a55f5a431350d4d00d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M net/socket/ssl_client_socket_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 2 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
davidben
4 years ago (2016-12-22 13:55:18 UTC) #6
svaldez
lgtm
3 years, 11 months ago (2017-01-12 16:14:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601493002/1
3 years, 11 months ago (2017-01-12 16:14:29 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:08:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b11fd211f55e332520f82a55f5a4...

Powered by Google App Engine
This is Rietveld 408576698