Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2601453002: Show IME in opt-in menu when there's one IME. (Closed)

Created:
4 years ago by Azure Wei
Modified:
4 years ago
Reviewers:
tdanderson, stevenjb
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show IME in opt-in menu when there's one IME. BUG=676252 TEST=Verified on local build. Committed: https://crrev.com/9786d46dddfaafccff9d11fc7e011dce9214fe13 Cr-Commit-Position: refs/heads/master@{#440540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Azure Wei
Please review this CL. Thanks!
4 years ago (2016-12-22 10:05:08 UTC) #3
stevenjb
lgtm
4 years ago (2016-12-22 19:20:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601453002/1
4 years ago (2016-12-22 22:35:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 23:35:00 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-22 23:38:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9786d46dddfaafccff9d11fc7e011dce9214fe13
Cr-Commit-Position: refs/heads/master@{#440540}

Powered by Google App Engine
This is Rietveld 408576698