Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2601403002: Expand recognized type trait value types from bool-or-enum to builtin-or-enum. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand recognized type trait value types from bool-or-enum to builtin-or-enum. BUG=640749 Review-Url: https://codereview.chromium.org/2601403002 Cr-Commit-Position: refs/heads/master@{#441691} Committed: https://chromium.googlesource.com/chromium/src/+/2bdc5448ead4f9aa4b8cb85c0d39218c8c378158

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/loosly/loosely/g #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/fields-original.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Łukasz Anforowicz
Daniel, can you PTAL?
3 years, 11 months ago (2017-01-04 18:19:44 UTC) #2
dcheng
lgtm https://codereview.chromium.org/2601403002/diff/1/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc File tools/clang/rewrite_to_chrome_style/tests/fields-original.cc (right): https://codereview.chromium.org/2601403002/diff/1/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc#newcode155 tools/clang/rewrite_to_chrome_style/tests/fields-original.cc:155: // Some type traits have int type. Example ...
3 years, 11 months ago (2017-01-05 04:18:52 UTC) #3
Łukasz Anforowicz
Thanks. https://codereview.chromium.org/2601403002/diff/1/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc File tools/clang/rewrite_to_chrome_style/tests/fields-original.cc (right): https://codereview.chromium.org/2601403002/diff/1/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc#newcode155 tools/clang/rewrite_to_chrome_style/tests/fields-original.cc:155: // Some type traits have int type. Example ...
3 years, 11 months ago (2017-01-05 17:22:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601403002/20001
3 years, 11 months ago (2017-01-05 17:22:33 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:34:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2bdc5448ead4f9aa4b8cb85c0d39...

Powered by Google App Engine
This is Rietveld 408576698