Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2601283002: Use AccountIdKey to identify Active Directory accounts. (Closed)

Created:
3 years, 11 months ago by Roman Sorokin (ftl)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use AccountIdKey to identify Active Directory accounts. It ties SessionManager, AuthPolicy, Cryptohome BUG=677497 TEST=manual Review-Url: https://codereview.chromium.org/2601283002 Cr-Commit-Position: refs/heads/master@{#443547} Committed: https://chromium.googlesource.com/chromium/src/+/65de674cb37522bb78bfe5f0f29a0f9899384d8b

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chromeos/dbus/auth_policy_client.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Roman Sorokin (ftl)
Thiemo, Alex, PTAL. Thanks!
3 years, 11 months ago (2016-12-29 16:48:40 UTC) #4
Thiemo Nagel
https://codereview.chromium.org/2601283002/diff/1/chromeos/dbus/auth_policy_client.cc File chromeos/dbus/auth_policy_client.cc (right): https://codereview.chromium.org/2601283002/diff/1/chromeos/dbus/auth_policy_client.cc#newcode68 chromeos/dbus/auth_policy_client.cc:68: writer.AppendString(account_id.GetAccountIdKey()); I'm already changing this in https://codereview.chromium.org/2608573002/ which probably ...
3 years, 11 months ago (2016-12-29 16:58:20 UTC) #5
Alexander Alekseev
lgtm
3 years, 11 months ago (2017-01-11 17:17:44 UTC) #12
Thiemo Nagel
lgtm
3 years, 11 months ago (2017-01-11 17:35:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601283002/20001
3 years, 11 months ago (2017-01-11 17:36:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601283002/20001
3 years, 11 months ago (2017-01-13 13:07:56 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:43:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/65de674cb37522bb78bfe5f0f29a...

Powered by Google App Engine
This is Rietveld 408576698