Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2601233002: Revert of Add LevelDB database names to tracing path for easier debugging (Closed)

Created:
3 years, 11 months ago by ssid
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add LevelDB database names to tracing path for easier debugging (patchset #2 id:40001 of https://codereview.chromium.org/2399903004/ ) Reason for revert: We identified the largest consumer of memory in leveldb_proto databases and fixed it crbug.com/662019. It is not safe to add dumps with database names since new clients of leveldb_proto might not update the whitelist and we will miss the memory usage. Original issue's description: > Add LevelDB database names to tracing path for easier debugging > > The data from field trials show large databases, but not sure what are > their names. So, adding names to the path. > > BUG=645126 > > Committed: https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121 > Cr-Commit-Position: refs/heads/master@{#424055} TBR=primiano@chromium.org,nyquist@chromium.org,mathp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645126 Review-Url: https://codereview.chromium.org/2601233002 Cr-Commit-Position: refs/heads/master@{#442782} Committed: https://chromium.googlesource.com/chromium/src/+/c5f7441b83ffcb113514512a65ca5910a9b5115b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M base/trace_event/memory_infra_background_whitelist.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/leveldb_proto/leveldb_database.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ssid
Created Revert of Add LevelDB database names to tracing path for easier debugging
3 years, 11 months ago (2016-12-29 02:20:23 UTC) #1
Primiano Tucci (use gerrit)
lgtm
3 years, 11 months ago (2017-01-06 13:30:40 UTC) #2
ssid
On 2017/01/06 13:30:40, Primiano Tucci (back but slow) wrote: > lgtm Tommy, ptal thanks.
3 years, 11 months ago (2017-01-10 05:12:03 UTC) #3
nyquist
lgtm
3 years, 11 months ago (2017-01-11 00:02:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601233002/1
3 years, 11 months ago (2017-01-11 00:04:23 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 03:41:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c5f7441b83ffcb113514512a65ca...

Powered by Google App Engine
This is Rietveld 408576698