Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2601213002: [ignition] Make a DCHECK in ConstantArrayBuilder more useful (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
mythria, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Make a DCHECK in ConstantArrayBuilder more useful This triggered on a CL I was working on today, figured I'd share my work. R=mythria@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2601213002 Cr-Commit-Position: refs/heads/master@{#42043} Committed: https://chromium.googlesource.com/v8/v8/+/a0eb5ab5fc79a2a14aeecab07e0e960249d39e0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/interpreter/constant-array-builder.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/interpreter/constant-array-builder.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 11 months ago (2016-12-29 01:14:30 UTC) #1
rmcilroy
Awesome, LGTM, thanks
3 years, 11 months ago (2017-01-03 09:39:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601213002/1
3 years, 11 months ago (2017-01-03 18:38:45 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:05:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a0eb5ab5fc79a2a14aeecab07e0e960249d...

Powered by Google App Engine
This is Rietveld 408576698