Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2601193003: Created a test page for window.history.[push/replace]State() tests. (Closed)

Created:
3 years, 11 months ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created a test page for window.history.[push/replace]State() tests. BUG=673022 Review-Url: https://codereview.chromium.org/2601193003 Cr-Commit-Position: refs/heads/master@{#445620} Committed: https://chromium.googlesource.com/chromium/src/+/8d803d8748c29ace8226110df83b62a902e0e3c7

Patch Set 1 #

Total comments: 6

Patch Set 2 : eugene's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
M ios/testing/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ios/testing/data/http_server_files/state_operations.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A ios/testing/data/http_server_files/state_operations.js View 1 1 chunk +60 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
kkhorimoto
3 years, 11 months ago (2016-12-29 04:03:33 UTC) #2
kkhorimoto
PTAL, this blocks landing other test CLs
3 years, 11 months ago (2017-01-20 19:41:41 UTC) #3
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.html File ios/testing/data/http_server_files/state_operations.html (right): https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.html#newcode14 ios/testing/data/http_server_files/state_operations.html:14: <p></p> Add indentation? https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.js File ios/testing/data/http_server_files/state_operations.js (right): https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.js#newcode19 ...
3 years, 11 months ago (2017-01-20 21:55:04 UTC) #4
kkhorimoto
https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.html File ios/testing/data/http_server_files/state_operations.html (right): https://codereview.chromium.org/2601193003/diff/1/ios/testing/data/http_server_files/state_operations.html#newcode14 ios/testing/data/http_server_files/state_operations.html:14: <p></p> On 2017/01/20 21:55:04, Eugene But wrote: > Add ...
3 years, 11 months ago (2017-01-21 01:38:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601193003/20001
3 years, 11 months ago (2017-01-24 01:43:52 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 02:51:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8d803d8748c29ace8226110df83b...

Powered by Google App Engine
This is Rietveld 408576698