Remove indexed_db_messages.h.

Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484
Review-Url: https://codereview.chromium.org/2601163002
Cr-Commit-Position: refs/heads/master@{#441947}
Committed: https://chromium.googlesource.com/chromium/src/+/bcb0b710d7986c14c48c7bc872a70095aef10637

[Reilly Grant (use Gerrit), 2016-12-28 22:32:26]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 22:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-12-28 22:32:47]

Description was changed from

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary so the logic (and test for it) have been
removed.

BUG=627484
==========

to

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary so the logic (and test for it) have been
removed.

BUG=627484
==========

[Reilly Grant (use Gerrit), 2016-12-28 22:32:47]

reillyg@chromium.org changed reviewers:
+ cmumford@chromium.org, jln@chromium.org, sadrul@chromium.org

[Reilly Grant (use Gerrit), 2016-12-28 22:33:49]

Description was changed from

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary so the logic (and test for it) have been
removed.

BUG=627484
==========

to

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484
==========

[Reilly Grant (use Gerrit), 2016-12-28 22:34:41]

reillyg@chromium.org changed reviewers:
+ kenrb@chromium.org
- jln@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:36:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2016-12-28 22:36:51]

reillyg@chromium.org changed reviewers:
+ jam@chromium.org
- sadrul@chromium.org

[Reilly Grant (use Gerrit), 2016-12-28 22:36:52]

cmumford@, please do an IndexedDB review.
kenrb@, please do an IPC review (easy, I deleted an empty file).
jam@, please review content/browser/render_host.
sadrul@, please ignore the last message.

[Reilly Grant (use Gerrit), 2016-12-28 22:49:26]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 22:49:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 23:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 23:08:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2016-12-29 00:21:09]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 00:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 00:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 00:56:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kenrb, 2016-12-29 05:59:25]

ipc lgtm

[jam, 2016-12-29 16:35:35]

lgtm

[Reilly Grant (use Gerrit), 2016-12-29 19:54:46]

Handle null callbacks in unit tests.

[Reilly Grant (use Gerrit), 2016-12-29 19:54:48]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 19:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 20:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 20:29:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-12-29 22:04:20]

Set up the factory on the right thread.

[Reilly Grant (use Gerrit), 2016-12-29 22:13:07]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 22:13:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 00:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 00:32:30]

Dry run: This issue passed the CQ dry run.

[cmumford, 2017-01-05 00:29:02]

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_callbacks.cc:135: void
OnConnectionError();
No longer need to include indexed_db_blob_info.h

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database_unittest.cc (left):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database_unittest.cc:234:
TEST_F(IndexedDBDatabaseTest, ConnectionRequestsNoLongerValid) {
I'm probably overlooking something, but why is this test no longer valid? Don't
we want to have the same test with the Mojo connection going away?

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_dispatcher_host.h (left):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_dispatcher_host.h:35: // Handles all
IndexedDB related messages from a particular renderer process.
No longer need to include content/public/browser/browser_associated_interface.h
and content/public/browser/browser_message_filter.h

https://codereview.chromium.org/2601163002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:2632:
indexed_db_factory_->Bind(std::move(request));
Do we need to check if indexed_db_factory_.is_bound() here?

https://codereview.chromium.org/2601163002/diff/80001/content/common/indexed_...
File content/common/indexed_db/indexed_db_messages.h (left):

https://codereview.chromium.org/2601163002/diff/80001/content/common/indexed_...
content/common/indexed_db/indexed_db_messages.h:9: #define IPC_MESSAGE_START
IndexedDBMsgStart
I believe you can delete IndexedDBMsgStart from ipc/ipc_message_start.h too.

[Reilly Grant (use Gerrit), 2017-01-06 02:22:00]

Addressed cmumford's feedback.

[Reilly Grant (use Gerrit), 2017-01-06 02:22:05]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 02:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-01-06 02:23:35]

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_callbacks.cc:135: void
OnConnectionError();
On 2017/01/05 00:29:01, cmumford wrote:
> No longer need to include indexed_db_blob_info.h

Done.

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database_unittest.cc (left):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database_unittest.cc:234:
TEST_F(IndexedDBDatabaseTest, ConnectionRequestsNoLongerValid) {
On 2017/01/05 00:29:01, cmumford wrote:
> I'm probably overlooking something, but why is this test no longer valid?
Don't
> we want to have the same test with the Mojo connection going away?

We discussed this offline.

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_dispatcher_host.h (left):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/indexed...
content/browser/indexed_db/indexed_db_dispatcher_host.h:35: // Handles all
IndexedDB related messages from a particular renderer process.
On 2017/01/05 00:29:01, cmumford wrote:
> No longer need to include
content/public/browser/browser_associated_interface.h
> and content/public/browser/browser_message_filter.h

Done.

https://codereview.chromium.org/2601163002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2601163002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:2632:
indexed_db_factory_->Bind(std::move(request));
On 2017/01/05 00:29:02, cmumford wrote:
> Do we need to check if indexed_db_factory_.is_bound() here?

Renamed this to AddBinding() to make it clear the object can take multiple
bindings.

https://codereview.chromium.org/2601163002/diff/80001/content/common/indexed_...
File content/common/indexed_db/indexed_db_messages.h (left):

https://codereview.chromium.org/2601163002/diff/80001/content/common/indexed_...
content/common/indexed_db/indexed_db_messages.h:9: #define IPC_MESSAGE_START
IndexedDBMsgStart
On 2017/01/05 00:29:01, cmumford wrote:
> I believe you can delete IndexedDBMsgStart from ipc/ipc_message_start.h too.

Done.

[commit-bot: I haz the power, 2017-01-06 03:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:28:31]

Dry run: This issue passed the CQ dry run.

[cmumford, 2017-01-06 14:58:23]

lgtm

[Reilly Grant (use Gerrit), 2017-01-06 16:18:52]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-01-06 16:18:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2601163002/#ps100001
(title: "Addressed cmumford's feedback.")

[commit-bot: I haz the power, 2017-01-06 16:19:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:24:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483719532848460,
"parent_rev": "8739cd56aa328f7972c60cba5f0d3348a108c273", "commit_rev":
"bcb0b710d7986c14c48c7bc872a70095aef10637"}

[commit-bot: I haz the power, 2017-01-06 16:25:28]

Description was changed from

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484
==========

to

==========
Remove indexed_db_messages.h.

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484

Review-Url: https://codereview.chromium.org/2601163002
Cr-Commit-Position: refs/heads/master@{#441947}
Committed:
https://chromium.googlesource.com/chromium/src/+/bcb0b710d7986c14c48c7bc872a7...
==========

[commit-bot: I haz the power, 2017-01-06 16:25:29]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/bcb0b710d7986c14c48c7bc872a7...