Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2601123002: Remove unnecessary language_mode arg from Parser::DefaultConstructor (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unnecessary language_mode arg from Parser::DefaultConstructor This looks like it was leftover from strong mode; default class constructors are always in strict mode. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2601123002 Cr-Commit-Position: refs/heads/master@{#41994} Committed: https://chromium.googlesource.com/v8/v8/+/e752c31e29c845dd3d3e16c12c9d42697efc7c7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/parser.cc View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
3 years, 11 months ago (2016-12-28 19:54:13 UTC) #1
adamk
ping?
3 years, 11 months ago (2016-12-29 21:12:47 UTC) #2
Dan Ehrenberg
lgtm
3 years, 11 months ago (2016-12-29 21:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601123002/1
3 years, 11 months ago (2016-12-29 21:42:41 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2016-12-29 22:12:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e752c31e29c845dd3d3e16c12c9d42697ef...

Powered by Google App Engine
This is Rietveld 408576698