Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2601103003: CSS Animations: fix flaky zoom-responsive-transform-animation.html (Closed)

Created:
3 years, 11 months ago by Eric Willigers
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Animations: fix flaky zoom-responsive-transform-animation.html We now wait for the compositor before declaring the test complete. BUG=669911 Committed: https://crrev.com/074ef8e966b6a2a10f0a6a8939d26b758dc69c76 Cr-Commit-Position: refs/heads/master@{#441084}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unneeded line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation.html View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation-expected.html View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Eric Willigers
3 years, 11 months ago (2016-12-29 08:22:41 UTC) #4
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2601103003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2601103003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode2164 third_party/WebKit/LayoutTests/TestExpectations:2164: # Added 2016-11-30 No need for this line ...
3 years, 11 months ago (2017-01-03 00:01:26 UTC) #7
Eric Willigers
https://codereview.chromium.org/2601103003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2601103003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode2164 third_party/WebKit/LayoutTests/TestExpectations:2164: # Added 2016-11-30 On 2017/01/03 00:01:26, alancutter wrote: > ...
3 years, 11 months ago (2017-01-03 00:07:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601103003/20001
3 years, 11 months ago (2017-01-03 01:29:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 01:33:57 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 01:36:44 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/074ef8e966b6a2a10f0a6a8939d26b758dc69c76
Cr-Commit-Position: refs/heads/master@{#441084}

Powered by Google App Engine
This is Rietveld 408576698