Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2601103002: Made CookieStoreIOS(PersistentCookieStore, NSHTTPCookieStorage) private. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made CookieStoreIOS(PersistentCookieStore, NSHTTPCookieStorage) private. This constructor is used only by implementation and should not be public BUG=676144 Committed: https://crrev.com/2cbccb7fa8907c3fa53840187e11613a5f307270 Cr-Commit-Position: refs/heads/master@{#441033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M ios/net/cookies/cookie_store_ios.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 2 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2016-12-28 19:23:13 UTC) #2
Eugene But (OOO till 7-30)
Mark?
3 years, 11 months ago (2016-12-29 21:53:39 UTC) #7
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-30 09:20:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601103002/1
3 years, 11 months ago (2016-12-30 16:24:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-30 16:28:25 UTC) #13
stubz5150
3 years, 11 months ago (2016-12-31 22:30:03 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cbccb7fa8907c3fa53840187e11613a5f307270
Cr-Commit-Position: refs/heads/master@{#441033}

Powered by Google App Engine
This is Rietveld 408576698