Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2601093002:
Use the correct omnibox icon for extension URLs (Closed)
DescriptionUse the correct omnibox icon for extension URLs
https://crrev.com/2555063003 added an omnibox icon for extension URLs but
was using the wrong asset. This CL updates the icon with a slightly smaller one
suggested by UI team.
Screenshots:
Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM
New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc
Committed: https://crrev.com/c45187706ce1ff6a35f20bfd197825bbb6a6f332
Cr-Commit-Position: refs/heads/master@{#440899}
Patch Set 1 #
Messages
Total messages: 14 (8 generated)
meacer@chromium.org changed reviewers: + jam@chromium.org
jam: Can you please take a look? All other owners are ooo :)
lgtm
Description was changed from ========== Use the correct omnibox icon for extension URLs BUG=453093 ========== to ========== Use the correct omnibox icon for extension URLs https://crrev.com/ 2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc ==========
Description was changed from ========== Use the correct omnibox icon for extension URLs https://crrev.com/ 2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc ========== to ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc ==========
Thanks jam! Updated the CL description and added screenshots.
The CQ bit was checked by meacer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482959298931960, "parent_rev":
"7c5ba8c6f23a6ec7d74b9087f2a956ba729d7811", "commit_rev":
"ec447528cf60c2de42f4875a3936bd1df74c349b"}
Message was sent while issue was closed.
Description was changed from ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc ========== to ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Review-Url: https://codereview.chromium.org/2601093002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Review-Url: https://codereview.chromium.org/2601093002 ========== to ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Review-Url: https://codereview.chromium.org/2601093002 BUG=453093 ==========
Message was sent while issue was closed.
Description was changed from ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Review-Url: https://codereview.chromium.org/2601093002 BUG=453093 ========== to ========== Use the correct omnibox icon for extension URLs https://crrev.com/2555063003 added an omnibox icon for extension URLs but was using the wrong asset. This CL updates the icon with a slightly smaller one suggested by UI team. Screenshots: Current: https://drive.google.com/open?id=0B9q2eN9gDoUIQ2JLSzJiY3dEZXM New: https://drive.google.com/open?id=0B9q2eN9gDoUId081S1EwcDJTWXc Committed: https://crrev.com/c45187706ce1ff6a35f20bfd197825bbb6a6f332 Cr-Commit-Position: refs/heads/master@{#440899} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c45187706ce1ff6a35f20bfd197825bbb6a6f332 Cr-Commit-Position: refs/heads/master@{#440899} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
