Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2601033002: Minor clean-up on WindowProxy::disposeContext() (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor clean-up on WindowProxy::disposeContext() We don't need to check isContextInitialized() in clearForClose() and clearForNavigation() because it is already checked in WindowProxy::disposeContext(). Also this CL moves the ScriptState::Scope into disposeContext() Though we don't need to enter ScriptState::Scope in case of clearForClose() by accident, it looks safer to enter the scope always. BUG=677253 Committed: https://crrev.com/488433ae435fbcd7ea4eac85f7042e7623f6bdef Cr-Commit-Position: refs/heads/master@{#440839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
haraken
PTAL
3 years, 11 months ago (2016-12-28 08:33:21 UTC) #2
Yuki
LGTM.
3 years, 11 months ago (2016-12-28 08:45:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601033002/1
3 years, 11 months ago (2016-12-28 08:46:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 10:05:07 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/488433ae435fbcd7ea4eac85f7042e7623f6bdef
Cr-Commit-Position: refs/heads/master@{#440839}

Powered by Google App Engine
This is Rietveld 408576698