Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 2600993002: [runtime] Remove a few more "HANDLE"s from CONVERT_ARG_HANDLEs (Closed)

Created:
3 years, 12 months ago by adamk
Modified:
3 years, 12 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove a few more "HANDLE"s from CONVERT_ARG_HANDLEs The rest of the cases I found are places where the runtime function calls some API that takes handles but itself uses HandleScopes internally where needed. R=gsathya@chromium.org BUG=v8:5783 Review-Url: https://codereview.chromium.org/2600993002 Cr-Commit-Position: refs/heads/master@{#41967} Committed: https://chromium.googlesource.com/v8/v8/+/121bf38bc0a2973476ba378ddd3ff3b5f97ae494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/runtime/runtime-function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
3 years, 12 months ago (2016-12-27 21:06:29 UTC) #1
gsathya
lgtm
3 years, 12 months ago (2016-12-27 21:14:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600993002/1
3 years, 12 months ago (2016-12-27 21:26:03 UTC) #4
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 21:51:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/121bf38bc0a2973476ba378ddd3ff3b5f97...

Powered by Google App Engine
This is Rietveld 408576698