Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: appengine/findit/libs/gitiles/gitiles_repository.py

Issue 2600983002: inlined GitilesRepository._DownloadChangeLogData (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/test/help_triage_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/libs/gitiles/gitiles_repository.py
diff --git a/appengine/findit/libs/gitiles/gitiles_repository.py b/appengine/findit/libs/gitiles/gitiles_repository.py
index 0fdad6c3abad97f082d873c94de60096c9265bb0..599724c3195c934eb3ca78be2afefe04a1bed192 100644
--- a/appengine/findit/libs/gitiles/gitiles_repository.py
+++ b/appengine/findit/libs/gitiles/gitiles_repository.py
@@ -87,10 +87,6 @@ class GitilesRepository(GitRepository):
return datetime.strptime(datetime_string, date_format)
- def _DownloadChangeLogData(self, revision):
- url = '%s/+/%s' % (self.repo_url, revision)
- return url, self._SendRequestForJsonResponse(url)
-
def _ParseChangeLogFromLogData(self, data):
commit_position, code_review_url = (
commit_util.ExtractCommitPositionAndCodeReviewUrl(data['message']))
@@ -121,7 +117,8 @@ class GitilesRepository(GitRepository):
def GetChangeLog(self, revision):
"""Returns the change log of the given revision."""
- _, data = self._DownloadChangeLogData(revision)
+ url = '%s/+/%s' % (self.repo_url, revision)
+ data = self._SendRequestForJsonResponse(url)
if not data:
return None
« no previous file with comments | « appengine/findit/handlers/test/help_triage_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698