Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: appengine/findit/handlers/test/help_triage_test.py

Issue 2600983002: inlined GitilesRepository._DownloadChangeLogData (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/libs/gitiles/gitiles_repository.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/test/help_triage_test.py
diff --git a/appengine/findit/handlers/test/help_triage_test.py b/appengine/findit/handlers/test/help_triage_test.py
index 6f12e30341ff8ee3a913f282e1bcf1163dadd16e..506a8ce619add6948613dedd61e18eb245ce172b 100644
--- a/appengine/findit/handlers/test/help_triage_test.py
+++ b/appengine/findit/handlers/test/help_triage_test.py
@@ -129,6 +129,16 @@ EXPECTED_RESULTS_121 = {
}
+def _MockGetChangeLog(repo, revision):
+ file_name = os.path.join(
+ os.path.dirname(__file__), 'data', 'help_triage_test_data',
+ 'change_log_' + revision)
+ with open(file_name) as f:
+ commit_log = f.read()
+
+ data = json.loads(commit_log[len(')]}\'\n'):])
+ return repo._ParseChangeLogFromLogData(data)
+
class HelpTriageTest(testing.AppengineTestCase):
app_module = webapp2.WSGIApplication([
@@ -154,23 +164,13 @@ class HelpTriageTest(testing.AppengineTestCase):
build.put()
return build
- def _MockDownloadChangeLogData(self, revision):
- file_name = os.path.join(
- os.path.dirname(__file__), 'data', 'help_triage_test_data',
- 'change_log_' + revision)
- with open(file_name) as f:
- commit_log = f.read()
- return revision, json.loads(commit_log[len(')]}\'\n'):])
-
def setUp(self):
super(HelpTriageTest, self).setUp()
self.master_name = 'm'
self.builder_name = 'b'
self.mock_current_user(user_email='test@chromium.org', is_admin=True)
- self.mock(build_util, 'DownloadBuildData',
- self._MockDownloadBuildData)
- self.mock(GitilesRepository, '_DownloadChangeLogData',
- self._MockDownloadChangeLogData)
+ self.mock(build_util, 'DownloadBuildData', self._MockDownloadBuildData)
+ self.mock(GitilesRepository, 'GetChangeLog', _MockGetChangeLog)
def _CreateAnalysis(self, build_number, first_failure, last_pass=None):
analysis = WfAnalysis.Create(
« no previous file with comments | « no previous file | appengine/findit/libs/gitiles/gitiles_repository.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698