Implement HTTP/2 settings field trial parameters.

Implement HTTP/2 settings field trial parameters.

* Add |http2_settings| field trial parameter to HTTP/2 trial group.
* Set max header table size, max concurrent pushed streams, and max
  receiving window size values in |http2_settings| in
  HttpNetworkSession.
* Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to
  SpdySession.  Remove |stream_max_recv_window_size| from this path.
* Extract max header table size, max concurrent pushed streams, and max
  receiving window size values from |http2_settings| in SpdySession.
* Move max header table size and max concurrent pushed streams default
  value from SpdySession to HttpNetworkSession.
* Add |http2_settings| to SpdySessionDependencies; remove
  |stream_max_recv_window_size|.

BUG=622737
Committed: https://crrev.com/3171a243c6b5fbaba264a71e78dd36a6b5eb47d2
Cr-Commit-Position: refs/heads/master@{#440871}

[Bence, 2016-12-27 20:07:08]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 20:07:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 20:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:59:32]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-12-27 21:01:07]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-12-27 21:01:08]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-12-27 22:32:43]

Just a few minor comments.

https://codereview.chromium.org/2600973002/diff/1/net/http/http_network_sessi...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/2600973002/diff/1/net/http/http_network_sessi...
net/http/http_network_session.cc:479: }
nit: I think this method can be a free function in an anon-namespace since it
doesn't appear to touch any class members.

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:721: DCHECK(settings_.find(SETTINGS_HEADER_TABLE_SIZE)
!= settings_.end());
Consider base::ContainsKey(settings_, SETTINGS_foo);

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:2663: if (setting.second == 4096)
Can we define these magic numbers somewhere?

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:1095: const SettingsMap settings_;
nit: perhaps this should be initial_settings_?

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session_pool.h
File net/spdy/spdy_session_pool.h (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session_pool....
net/spdy/spdy_session_pool.h:234: const SettingsMap settings_;
nit: comment

[Bence, 2016-12-27 23:45:13]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 23:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 00:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 00:51:51]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-12-28 00:53:24]

Ryan: PTAL.  Thank you.

https://codereview.chromium.org/2600973002/diff/1/net/http/http_network_sessi...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/2600973002/diff/1/net/http/http_network_sessi...
net/http/http_network_session.cc:479: }
On 2016/12/27 22:32:43, Ryan Hamilton wrote:
> nit: I think this method can be a free function in an anon-namespace since it
> doesn't appear to touch any class members.

Done.

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:721: DCHECK(settings_.find(SETTINGS_HEADER_TABLE_SIZE)
!= settings_.end());
On 2016/12/27 22:32:43, Ryan Hamilton wrote:
> Consider base::ContainsKey(settings_, SETTINGS_foo);

Done.

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:2663: if (setting.second == 4096)
On 2016/12/27 22:32:43, Ryan Hamilton wrote:
> Can we define these magic numbers somewhere?

Done.

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:1095: const SettingsMap settings_;
On 2016/12/27 22:32:43, Ryan Hamilton wrote:
> nit: perhaps this should be initial_settings_?

Done.

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session_pool.h
File net/spdy/spdy_session_pool.h (right):

https://codereview.chromium.org/2600973002/diff/1/net/spdy/spdy_session_pool....
net/spdy/spdy_session_pool.h:234: const SettingsMap settings_;
On 2016/12/27 22:32:43, Ryan Hamilton wrote:
> nit: comment

Done.

[Ryan Hamilton, 2016-12-28 18:35:14]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-12-28 18:35:15]

lgtm

[commit-bot: I haz the power, 2016-12-28 18:35:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 18:40:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482950114824790,
"parent_rev": "e9df5bf4cc74dfd3eeb71c4a06b951711accfb70", "commit_rev":
"e7c554f47af696954712867468d1104b8bba8d1f"}

[commit-bot: I haz the power, 2016-12-28 18:40:57]

Description was changed from

==========
Implement HTTP/2 settings field trial parameters.

* Add |http2_settings| field trial parameter to HTTP/2 trial group.
* Set max header table size, max concurrent pushed streams, and max
  receiving window size values in |http2_settings| in
  HttpNetworkSession.
* Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to
  SpdySession.  Remove |stream_max_recv_window_size| from this path.
* Extract max header table size, max concurrent pushed streams, and max
  receiving window size values from |http2_settings| in SpdySession.
* Move max header table size and max concurrent pushed streams default
  value from SpdySession to HttpNetworkSession.
* Add |http2_settings| to SpdySessionDependencies; remove
  |stream_max_recv_window_size|.

BUG=622737
==========

to

==========
Implement HTTP/2 settings field trial parameters.

* Add |http2_settings| field trial parameter to HTTP/2 trial group.
* Set max header table size, max concurrent pushed streams, and max
  receiving window size values in |http2_settings| in
  HttpNetworkSession.
* Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to
  SpdySession.  Remove |stream_max_recv_window_size| from this path.
* Extract max header table size, max concurrent pushed streams, and max
  receiving window size values from |http2_settings| in SpdySession.
* Move max header table size and max concurrent pushed streams default
  value from SpdySession to HttpNetworkSession.
* Add |http2_settings| to SpdySessionDependencies; remove
  |stream_max_recv_window_size|.

BUG=622737

Review-Url: https://codereview.chromium.org/2600973002
==========

[commit-bot: I haz the power, 2016-12-28 18:40:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:49:39]

Description was changed from

==========
Implement HTTP/2 settings field trial parameters.

* Add |http2_settings| field trial parameter to HTTP/2 trial group.
* Set max header table size, max concurrent pushed streams, and max
  receiving window size values in |http2_settings| in
  HttpNetworkSession.
* Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to
  SpdySession.  Remove |stream_max_recv_window_size| from this path.
* Extract max header table size, max concurrent pushed streams, and max
  receiving window size values from |http2_settings| in SpdySession.
* Move max header table size and max concurrent pushed streams default
  value from SpdySession to HttpNetworkSession.
* Add |http2_settings| to SpdySessionDependencies; remove
  |stream_max_recv_window_size|.

BUG=622737

Review-Url: https://codereview.chromium.org/2600973002
==========

to

==========
Implement HTTP/2 settings field trial parameters.

* Add |http2_settings| field trial parameter to HTTP/2 trial group.
* Set max header table size, max concurrent pushed streams, and max
  receiving window size values in |http2_settings| in
  HttpNetworkSession.
* Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to
  SpdySession.  Remove |stream_max_recv_window_size| from this path.
* Extract max header table size, max concurrent pushed streams, and max
  receiving window size values from |http2_settings| in SpdySession.
* Move max header table size and max concurrent pushed streams default
  value from SpdySession to HttpNetworkSession.
* Add |http2_settings| to SpdySessionDependencies; remove
  |stream_max_recv_window_size|.

BUG=622737

Committed: https://crrev.com/3171a243c6b5fbaba264a71e78dd36a6b5eb47d2
Cr-Commit-Position: refs/heads/master@{#440871}
==========

[commit-bot: I haz the power, 2017-01-02 15:49:40]

Patchset 2 (id:??) landed as
https://crrev.com/3171a243c6b5fbaba264a71e78dd36a6b5eb47d2
Cr-Commit-Position: refs/heads/master@{#440871}