Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2600963002: [ios] Do not use CRWWebController in MainController. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Do not use CRWWebController in MainController. New code uses web::NavigationManager which is the same program flow. Old code would tolerate nil CRWWebController, while the new code will crash (which should not happen in practice). BUG=616288 Committed: https://crrev.com/d4e617ae3c13cb02ac784df04deb8e44b82de395 Cr-Commit-Position: refs/heads/master@{#440854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M ios/chrome/app/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/app/main_controller.mm View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2016-12-27 20:43:38 UTC) #3
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-28 09:37:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600963002/1
3 years, 11 months ago (2016-12-28 16:36:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 16:45:56 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e617ae3c13cb02ac784df04deb8e44b82de395
Cr-Commit-Position: refs/heads/master@{#440854}

Powered by Google App Engine
This is Rietveld 408576698