Cleanup the preconnect to proxy code and Job controller code

Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single
field trial. Next CL will add the variation param
|race_preconnects_to_proxies| to experiment with racing the alternative
and main jobs for proxy preconnects.

(2) Remove an extra parameter in
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471, 671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0
Cr-Commit-Position: refs/heads/master@{#440893}

[tbansal1, 2016-12-27 18:57:53]

Description was changed from

==========
Cleanup

BUG=
==========

to

==========
Cleanup the preconnect to proxy code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

[tbansal1, 2016-12-27 18:58:21]

Description was changed from

==========
Cleanup the preconnect to proxy code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

[tbansal1, 2016-12-27 19:00:10]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single field
trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

[tbansal1, 2016-12-27 19:01:39]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single field
trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471
==========

[tbansal1, 2016-12-27 19:02:02]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
==========

[tbansal1, 2016-12-27 19:05:37]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-12-27 19:05:45]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-27 19:06:38]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to test racing the alternative and main
jobs for proxy preconnects.
(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to experiment with racing the alternative 
and main jobs for proxy preconnects.

(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2016-12-27 19:06:42]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2016-12-27 19:06:48]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:07:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-27 19:07:05]

tbansal@chromium.org changed reviewers:
+ rch@chromium.org

[tbansal1, 2016-12-27 19:07:06]

rch: ptal. Thanks.

[commit-bot: I haz the power, 2016-12-27 19:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 19:14:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2016-12-27 19:23:27]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 19:23:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 20:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:21:44]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-12-28 18:44:38]

nice cleanup!

https://codereview.chromium.org/2600943002/diff/40001/net/http/http_network_s...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/2600943002/diff/40001/net/http/http_network_s...
net/http/http_network_session.h:200: bool
restrict_to_one_preconnect_for_proxies;
Does this need to be initialized false in the .cc file?

[tbansal1, 2016-12-28 20:13:20]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 20:13:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-28 20:15:06]

rch: ptal. thanks.

https://codereview.chromium.org/2600943002/diff/40001/net/http/http_network_s...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/2600943002/diff/40001/net/http/http_network_s...
net/http/http_network_session.h:200: bool
restrict_to_one_preconnect_for_proxies;
On 2016/12/28 18:44:38, Ryan Hamilton wrote:
> Does this need to be initialized false in the .cc file?

Done. I was relying on network_session_configurator.cc to explicitly set it to
true or false based on field trials, but this is also useful.

[Ryan Hamilton, 2016-12-28 21:02:48]

lgtm

[commit-bot: I haz the power, 2016-12-28 21:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:08:16]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-28 21:08:31]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:08:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 21:12:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482959311019830,
"parent_rev": "8fdc479cc2280f655a8b9b0b2e9c392e907a1051", "commit_rev":
"54bae35a895f499aaccb9b2319aac235f1d11a6b"}

[commit-bot: I haz the power, 2016-12-28 21:13:22]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to experiment with racing the alternative 
and main jobs for proxy preconnects.

(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to experiment with racing the alternative 
and main jobs for proxy preconnects.

(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2600943002
==========

[commit-bot: I haz the power, 2016-12-28 21:13:23]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2017-01-02 15:50:19]

Description was changed from

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single 
field trial. Next CL will add the variation param 
|race_preconnects_to_proxies| to experiment with racing the alternative 
and main jobs for proxy preconnects.

(2) Remove an extra parameter in 
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2600943002
==========

to

==========
Cleanup the preconnect to proxy code and Job controller code

(1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network
session params. This allows us to run multiple experiments using a single
field trial. Next CL will add the variation param
|race_preconnects_to_proxies| to experiment with racing the alternative
and main jobs for proxy preconnects.

(2) Remove an extra parameter in
HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method.

BUG=667471,671291
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0
Cr-Commit-Position: refs/heads/master@{#440893}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:20]

Patchset 3 (id:??) landed as
https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0
Cr-Commit-Position: refs/heads/master@{#440893}