Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2600893002: Prerender: exclude AGSA from the PrerenderSilence experiment (Closed)

Created:
3 years, 12 months ago by pasko
Modified:
3 years, 11 months ago
Reviewers:
mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: exclude AGSA from the PrerenderSilence experiment Currently AGSA only uses ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR. The experiment will not take effect on these origins. Other 1st party apps are not using this prerender::Origin, as far as we know, and the use of it is restricted to 1st party, hence this change should not affect the experiment for other Android apps. BUG=640592 Committed: https://crrev.com/15e5a046b0af4a900f77ddeddf001de7c2b54251 Cr-Commit-Position: refs/heads/master@{#440750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 3 chunks +41 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pasko
3 years, 12 months ago (2016-12-26 17:31:24 UTC) #5
mattcary
lgtm
3 years, 12 months ago (2016-12-27 08:56:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600893002/1
3 years, 12 months ago (2016-12-27 12:14:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 12:18:58 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15e5a046b0af4a900f77ddeddf001de7c2b54251
Cr-Commit-Position: refs/heads/master@{#440750}

Powered by Google App Engine
This is Rietveld 408576698