Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 2600863002: Revert of [ServiceWorker] Mojofy PushEvent of Service Worker. (Closed)

Created:
3 years, 12 months ago by falken
Modified:
3 years, 12 months ago
CC:
Aaron Boodman, abarth-chromium, blink-worker-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, harkness+watch_chromium.org, horo+watch_chromium.org, jam, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mlamouri+watch-content_chromium.org, nhiroki, Peter Beverloo, qsr+mojo_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #3 id:40001 of https://codereview.chromium.org/2569993002/ ) Reason for revert: Causes crashes on canary. See https://crbug.com/676984 0x5eb4a4fa (chrome.dll + 0x000fa4fa ) base::Callback<void ,1,1>::Callback<void ,1,1>(base::Callback<void ,1,1> const &) 0x6003ec7d (chrome.dll -service_worker_version.cc:1095 ) content::ServiceWorkerVersion::OnSimpleEventFinished(int,content::ServiceWorkerStatusCode,base::Time) 0x5ff64f33 (chrome.dll -bind_internal.h:214 ) base::internal::FunctorTraits<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),void>::Invoke<scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode,base::Time>(void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode &&,base::Time &&) 0x5ff50241 (chrome.dll -bind_internal.h:285 ) base::internal::InvokeHelper<0,void>::MakeItSo<void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int,blink::WebServiceWorkerEventResult,base::Time>(void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int &&,blink::WebServiceWorkerEventResult &&,base::Time &&) 0x5ff655a6 (chrome.dll -bind_internal.h:339 ) base::internal::Invoker<base::internal::BindState<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion>,int>,void >::Run(base::internal::BindStateBase *,content::ServiceWorkerStatusCode &&,base::Time &&) 0x5fbe1b09 (chrome.dll -callback.h:85 ) base::internal::RunMixin<base::Callback<void ,1,1> >::Run(filesystem::mojom::FileError,__int64) 0x5fba0984 (chrome.dll -service_worker_event_dispatcher.mojom.cc:225 ) content::mojom::ServiceWorkerEventDispatcher_DispatchPushEvent_ForwardToCallback::Accept(mojo::Message *) 0x6037605b (chrome.dll -interface_endpoint_client.cc:336 ) mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message *) Original issue's description: > [ServiceWorker] Mojofy PushEvent of Service Worker. > > This CL converts push event IPCs into mojo interface: > ServiceWorkerMsg_PushEvent > ServiceWorkerHostMsg_PushEventFinished > > BUG=629701 > TEST=content_unittests > > Committed: https://crrev.com/35842853527f50a04662a6dfe2c3cd1b10cf5915 > Cr-Commit-Position: refs/heads/master@{#439739} TBR=leon.han@intel.com,peter@chromium.org,shimazu@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629701 Committed: https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9 Cr-Commit-Position: refs/heads/master@{#440693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -76 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 2 chunks +4 lines, -8 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 4 chunks +10 lines, -16 lines 0 comments Download
M content/common/service_worker/service_worker_event_dispatcher.mojom View 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/service_worker/service_worker_event_dispatcher.typemap View 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 7 chunks +26 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
falken
Created Revert of [ServiceWorker] Mojofy PushEvent of Service Worker.
3 years, 12 months ago (2016-12-26 03:55:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600863002/1
3 years, 12 months ago (2016-12-26 03:56:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-26 05:50:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9 Cr-Commit-Position: refs/heads/master@{#440693}
3 years, 12 months ago (2016-12-26 05:52:47 UTC) #8
shimazu
3 years, 11 months ago (2017-01-12 07:28:50 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2620333003/ by shimazu@chromium.org.

The reason for reverting is: Fixed the root cause of the crash.
https://crrev.com/64efa56e5bb67106cea0eb4033b866d9217d8324.

Powered by Google App Engine
This is Rietveld 408576698