DescriptionRevert of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #3 id:40001 of https://codereview.chromium.org/2569993002/ )
Reason for revert:
Causes crashes on canary. See https://crbug.com/676984
0x5eb4a4fa (chrome.dll + 0x000fa4fa ) base::Callback<void ,1,1>::Callback<void ,1,1>(base::Callback<void ,1,1> const &)
0x6003ec7d (chrome.dll -service_worker_version.cc:1095 ) content::ServiceWorkerVersion::OnSimpleEventFinished(int,content::ServiceWorkerStatusCode,base::Time)
0x5ff64f33 (chrome.dll -bind_internal.h:214 ) base::internal::FunctorTraits<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),void>::Invoke<scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode,base::Time>(void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode &&,base::Time &&)
0x5ff50241 (chrome.dll -bind_internal.h:285 ) base::internal::InvokeHelper<0,void>::MakeItSo<void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int,blink::WebServiceWorkerEventResult,base::Time>(void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int &&,blink::WebServiceWorkerEventResult &&,base::Time &&)
0x5ff655a6 (chrome.dll -bind_internal.h:339 ) base::internal::Invoker<base::internal::BindState<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion>,int>,void >::Run(base::internal::BindStateBase *,content::ServiceWorkerStatusCode &&,base::Time &&)
0x5fbe1b09 (chrome.dll -callback.h:85 ) base::internal::RunMixin<base::Callback<void ,1,1> >::Run(filesystem::mojom::FileError,__int64)
0x5fba0984 (chrome.dll -service_worker_event_dispatcher.mojom.cc:225 ) content::mojom::ServiceWorkerEventDispatcher_DispatchPushEvent_ForwardToCallback::Accept(mojo::Message *)
0x6037605b (chrome.dll -interface_endpoint_client.cc:336 ) mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message *)
Original issue's description:
> [ServiceWorker] Mojofy PushEvent of Service Worker.
>
> This CL converts push event IPCs into mojo interface:
> ServiceWorkerMsg_PushEvent
> ServiceWorkerHostMsg_PushEventFinished
>
> BUG=629701
> TEST=content_unittests
>
> Committed: https://crrev.com/35842853527f50a04662a6dfe2c3cd1b10cf5915
> Cr-Commit-Position: refs/heads/master@{#439739}
TBR=leon.han@intel.com,peter@chromium.org,shimazu@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629701
Committed: https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9
Cr-Commit-Position: refs/heads/master@{#440693}
Patch Set 1 #Messages
Total messages: 9 (4 generated)
|