Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2600853002: Merge "Windows: Fix the default font size for form controls in non-1.0 device scale factor." to M56 (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge "Windows: Fix the default font size for form controls in non-1.0 device scale factor." to M56 The font size was too small in DSF>1.0 because pointsToPixels() unnecessarily multiplied the value by device scale factor. Font sizes in this code should be treated as DIP size. BUG=674663 Review-Url: https://codereview.chromium.org/2587283002 Cr-Commit-Position: refs/heads/master@{#439724} (cherry picked from commit a5ade1a60231b618854923338a13c8a53f44ee95) Committed: https://chromium.googlesource.com/chromium/src/+/37448de2b9d69cd1286135bfaf0c3ac494d4f314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 11 months ago (2016-12-26 00:37:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37448de2b9d69cd1286135bfaf0c3ac494d4f314.

Powered by Google App Engine
This is Rietveld 408576698