Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2587283002: Windows: Fix the default font size for form controls in non-1.0 device scale factor. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows: Fix the default font size for form controls in non-1.0 device scale factor. The font size was too small in DSF>1.0 because pointsToPixels() unnecessarily multiplied the value by device scale factor. Font sizes in this code should be treated as DIP size. BUG=674663 Committed: https://crrev.com/a5ade1a60231b618854923338a13c8a53f44ee95 Cr-Commit-Position: refs/heads/master@{#439724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/popup-menu-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/popup-menu-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/calendar-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
tkent
kojii@, would you review this please?
4 years ago (2016-12-20 04:32:55 UTC) #6
kojii
lgtm
4 years ago (2016-12-20 05:56:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587283002/1
4 years ago (2016-12-20 05:59:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 06:10:10 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-20 06:14:54 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ade1a60231b618854923338a13c8a53f44ee95
Cr-Commit-Position: refs/heads/master@{#439724}

Powered by Google App Engine
This is Rietveld 408576698