Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2600833002: Use QuicStrCat instead of strings::Substitute and strings::SubstituteAndAppend which do not exist i… (Closed)

Created:
3 years, 12 months ago by Ryan Hamilton
Modified:
3 years, 11 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use QuicStrCat instead of strings::Substitute and strings::SubstituteAndAppend which do not exist in chrome. Merge internal change: 142860653 Committed: https://crrev.com/b64cf7a13299a4d19ac323414154d9fe9f584413 Cr-Commit-Position: refs/heads/master@{#440787}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M net/quic/core/quic_stream_sequencer_buffer.cc View 6 chunks +22 lines, -30 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Ryan Hamilton
3 years, 12 months ago (2016-12-26 23:42:10 UTC) #6
Jana
lgtm
3 years, 11 months ago (2016-12-27 20:48:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600833002/40001
3 years, 11 months ago (2016-12-27 20:49:12 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-27 20:55:39 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:09 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b64cf7a13299a4d19ac323414154d9fe9f584413
Cr-Commit-Position: refs/heads/master@{#440787}

Powered by Google App Engine
This is Rietveld 408576698